Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ require (
github.com/stackitcloud/stackit-sdk-go/services/logme v0.25.6
github.com/stackitcloud/stackit-sdk-go/services/mariadb v0.25.6
github.com/stackitcloud/stackit-sdk-go/services/objectstorage v1.7.0
github.com/stackitcloud/stackit-sdk-go/services/observability v0.17.0
github.com/stackitcloud/stackit-sdk-go/services/observability v0.24.0
github.com/stackitcloud/stackit-sdk-go/services/rabbitmq v0.26.0
github.com/stackitcloud/stackit-sdk-go/services/redis v0.25.6
github.com/stackitcloud/stackit-sdk-go/services/sfs v0.9.0
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,8 @@ github.com/stackitcloud/stackit-sdk-go/services/objectstorage v1.7.0 h1:UxnbsKm6
github.com/stackitcloud/stackit-sdk-go/services/objectstorage v1.7.0/go.mod h1:RFL4h6JZvpsyFYbdJ3+eINEkletzJQTfrPdd+yPT/fU=
github.com/stackitcloud/stackit-sdk-go/services/observability v0.17.0 h1:LGwCvvST0fwUgZ6bOxYIfu45qqTgv421ZS07UhKjZL8=
github.com/stackitcloud/stackit-sdk-go/services/observability v0.17.0/go.mod h1:9KdrXC5JS30Ay3mR0adb3vNdhca+qxiy/cPF5P4wehQ=
github.com/stackitcloud/stackit-sdk-go/services/observability v0.24.0 h1:KhuWPXr1hl8BFLGLSi6wjxh5o6OQXH9amfquMhYQROU=
github.com/stackitcloud/stackit-sdk-go/services/observability v0.24.0/go.mod h1:0fEZQHm729mBdvg4sNrAhM6KmHROHJSeS2FwCMRk46k=
github.com/stackitcloud/stackit-sdk-go/services/opensearch v0.24.6 h1:oTVx1+O177Ojn8OvXIOUbRSwtx7L59jhxDPrZEQFOfQ=
github.com/stackitcloud/stackit-sdk-go/services/opensearch v0.24.6/go.mod h1:6ZBeCCY6qG8w1oK7osf61Egyv3mp7Ahv6GDGxiarDGo=
github.com/stackitcloud/stackit-sdk-go/services/postgresflex v1.3.5 h1:H67e3KnHQx954yI8fuQmxXwRf/myqAdLg2KvxImp00g=
Expand Down
23 changes: 10 additions & 13 deletions internal/cmd/observability/credentials/create/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"github.com/stackitcloud/stackit-cli/internal/pkg/types"

"github.com/spf13/cobra"
"github.com/stackitcloud/stackit-sdk-go/services/observability"
observability "github.com/stackitcloud/stackit-sdk-go/services/observability/v1api"

"github.com/stackitcloud/stackit-cli/internal/pkg/args"
cliErr "github.com/stackitcloud/stackit-cli/internal/pkg/errors"
Expand All @@ -17,7 +17,6 @@ import (
"github.com/stackitcloud/stackit-cli/internal/pkg/print"
"github.com/stackitcloud/stackit-cli/internal/pkg/services/observability/client"
observabilityUtils "github.com/stackitcloud/stackit-cli/internal/pkg/services/observability/utils"
"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
)

const (
Expand Down Expand Up @@ -56,7 +55,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
return err
}

instanceLabel, err := observabilityUtils.GetInstanceName(ctx, apiClient, model.InstanceId, model.ProjectId)
instanceLabel, err := observabilityUtils.GetInstanceName(ctx, apiClient.DefaultAPI, model.InstanceId, model.ProjectId)
if err != nil {
params.Printer.Debug(print.ErrorLevel, "get instance name: %v", err)
instanceLabel = model.InstanceId
Expand All @@ -69,7 +68,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
}

// Call API
req := buildRequest(ctx, model, apiClient)
req := buildRequest(ctx, model, apiClient.DefaultAPI)
if err != nil {
return err
}
Expand Down Expand Up @@ -104,7 +103,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel,
}, nil
}

func buildRequest(ctx context.Context, model *inputModel, apiClient *observability.APIClient) observability.ApiCreateCredentialsRequest {
func buildRequest(ctx context.Context, model *inputModel, apiClient observability.DefaultAPI) observability.ApiCreateCredentialsRequest {
req := apiClient.CreateCredentials(ctx, model.InstanceId, model.ProjectId)
return req
}
Expand All @@ -117,15 +116,13 @@ func outputResult(p *print.Printer, outputFormat, instanceLabel string, resp *ob
return p.OutputResult(outputFormat, resp, func() error {
p.Outputf("Created credentials for instance %q.\n\n", instanceLabel)

if resp.Credentials != nil {
// The username field cannot be set by the user, so we only display it if it's not returned empty
username := *resp.Credentials.Username
if username != "" {
p.Outputf("Username: %s\n", username)
}

p.Outputf("Password: %s\n", utils.PtrString(resp.Credentials.Password))
// The username field cannot be set by the user, so we only display it if it's not returned empty
username := resp.Credentials.Username
if username != "" {
p.Outputf("Username: %s\n", username)
}

p.Outputf("Password: %s\n", resp.Credentials.Password)
return nil
})
}
12 changes: 6 additions & 6 deletions internal/cmd/observability/credentials/create/create_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"context"
"testing"

"github.com/stackitcloud/stackit-sdk-go/services/observability"
observability "github.com/stackitcloud/stackit-sdk-go/services/observability/v1api"

"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
"github.com/stackitcloud/stackit-cli/internal/pkg/testparams"
Expand All @@ -20,7 +20,7 @@ var projectIdFlag = globalflags.ProjectIdFlag
type testCtxKey struct{}

var testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo")
var testClient = &observability.APIClient{}
var testClient = &observability.APIClient{DefaultAPI: &observability.DefaultAPIService{}}
var testProjectId = uuid.NewString()
var testInstanceId = uuid.NewString()

Expand Down Expand Up @@ -50,7 +50,7 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
}

func fixtureRequest(mods ...func(request *observability.ApiCreateCredentialsRequest)) observability.ApiCreateCredentialsRequest {
request := testClient.CreateCredentials(testCtx, testInstanceId, testProjectId)
request := testClient.DefaultAPI.CreateCredentials(testCtx, testInstanceId, testProjectId)
for _, mod := range mods {
mod(&request)
}
Expand Down Expand Up @@ -142,10 +142,10 @@ func TestBuildRequest(t *testing.T) {

for _, tt := range tests {
t.Run(tt.description, func(t *testing.T) {
request := buildRequest(testCtx, tt.model, testClient)
request := buildRequest(testCtx, tt.model, testClient.DefaultAPI)

diff := cmp.Diff(request, tt.expectedRequest,
cmp.AllowUnexported(tt.expectedRequest),
cmp.AllowUnexported(tt.expectedRequest, observability.DefaultAPIService{}),
cmpopts.EquateComparable(testCtx),
)
if diff != "" {
Expand Down Expand Up @@ -182,7 +182,7 @@ func TestOutputResult(t *testing.T) {
name: "set response with credentials",
args: args{
resp: &observability.CreateCredentialsResponse{
Credentials: observability.NewCredentials("dummy-pw", "dummy-user"),
Credentials: *observability.NewCredentials("dummy-pw", "dummy-user"),
},
},
wantErr: false,
Expand Down
8 changes: 4 additions & 4 deletions internal/cmd/observability/credentials/delete/delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
observabilityUtils "github.com/stackitcloud/stackit-cli/internal/pkg/services/observability/utils"

"github.com/spf13/cobra"
"github.com/stackitcloud/stackit-sdk-go/services/observability"
observability "github.com/stackitcloud/stackit-sdk-go/services/observability/v1api"
)

const (
Expand Down Expand Up @@ -55,7 +55,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
return err
}

instanceLabel, err := observabilityUtils.GetInstanceName(ctx, apiClient, model.InstanceId, model.ProjectId)
instanceLabel, err := observabilityUtils.GetInstanceName(ctx, apiClient.DefaultAPI, model.InstanceId, model.ProjectId)
if err != nil {
params.Printer.Debug(print.ErrorLevel, "get instance name: %v", err)
instanceLabel = model.InstanceId
Expand All @@ -68,7 +68,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
}

// Call API
req := buildRequest(ctx, model, apiClient)
req := buildRequest(ctx, model, apiClient.DefaultAPI)
_, err = req.Execute()
if err != nil {
return fmt.Errorf("delete Observability credentials: %w", err)
Expand Down Expand Up @@ -104,7 +104,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
}, nil
}

func buildRequest(ctx context.Context, model *inputModel, apiClient *observability.APIClient) observability.ApiDeleteCredentialsRequest {
func buildRequest(ctx context.Context, model *inputModel, apiClient observability.DefaultAPI) observability.ApiDeleteCredentialsRequest {
req := apiClient.DeleteCredentials(ctx, model.InstanceId, model.ProjectId, model.Username)
return req
}
10 changes: 5 additions & 5 deletions internal/cmd/observability/credentials/delete/delete_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ import (
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"github.com/google/uuid"
"github.com/stackitcloud/stackit-sdk-go/services/observability"
observability "github.com/stackitcloud/stackit-sdk-go/services/observability/v1api"
)

var projectIdFlag = globalflags.ProjectIdFlag

type testCtxKey struct{}

var testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo")
var testClient = &observability.APIClient{}
var testClient = &observability.APIClient{DefaultAPI: &observability.DefaultAPIService{}}
var testProjectId = uuid.NewString()
var testInstanceId = uuid.NewString()

Expand Down Expand Up @@ -60,7 +60,7 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
}

func fixtureRequest(mods ...func(request *observability.ApiDeleteCredentialsRequest)) observability.ApiDeleteCredentialsRequest {
request := testClient.DeleteCredentials(testCtx, testInstanceId, testProjectId, testUsername)
request := testClient.DefaultAPI.DeleteCredentials(testCtx, testInstanceId, testProjectId, testUsername)
for _, mod := range mods {
mod(&request)
}
Expand Down Expand Up @@ -224,10 +224,10 @@ func TestBuildRequest(t *testing.T) {

for _, tt := range tests {
t.Run(tt.description, func(t *testing.T) {
request := buildRequest(testCtx, tt.model, testClient)
request := buildRequest(testCtx, tt.model, testClient.DefaultAPI)

diff := cmp.Diff(request, tt.expectedRequest,
cmp.AllowUnexported(tt.expectedRequest),
cmp.AllowUnexported(tt.expectedRequest, observability.DefaultAPIService{}),
cmpopts.EquateComparable(testCtx),
)
if diff != "" {
Expand Down
11 changes: 5 additions & 6 deletions internal/cmd/observability/credentials/list/list.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,9 @@ import (
"github.com/stackitcloud/stackit-cli/internal/pkg/services/observability/client"
observabilityUtils "github.com/stackitcloud/stackit-cli/internal/pkg/services/observability/utils"
"github.com/stackitcloud/stackit-cli/internal/pkg/tables"
"github.com/stackitcloud/stackit-cli/internal/pkg/utils"

"github.com/spf13/cobra"
"github.com/stackitcloud/stackit-sdk-go/services/observability"
observability "github.com/stackitcloud/stackit-sdk-go/services/observability/v1api"
)

const (
Expand Down Expand Up @@ -63,15 +62,15 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
}

// Call API
req := buildRequest(ctx, model, apiClient)
req := buildRequest(ctx, model, apiClient.DefaultAPI)
resp, err := req.Execute()
if err != nil {
return fmt.Errorf("list Observability credentials: %w", err)
}

credentials := resp.GetCredentials()

instanceLabel, err := observabilityUtils.GetInstanceName(ctx, apiClient, model.InstanceId, model.ProjectId)
instanceLabel, err := observabilityUtils.GetInstanceName(ctx, apiClient.DefaultAPI, model.InstanceId, model.ProjectId)
if err != nil {
params.Printer.Debug(print.ErrorLevel, "get instance name: %v", err)
instanceLabel = model.InstanceId
Expand Down Expand Up @@ -117,7 +116,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel,
}, nil
}

func buildRequest(ctx context.Context, model *inputModel, apiClient *observability.APIClient) observability.ApiListCredentialsRequest {
func buildRequest(ctx context.Context, model *inputModel, apiClient observability.DefaultAPI) observability.ApiListCredentialsRequest {
req := apiClient.ListCredentials(ctx, model.InstanceId, model.ProjectId)
return req
}
Expand All @@ -132,7 +131,7 @@ func outputResult(p *print.Printer, outputFormat, instanceLabel string, credenti
table.SetHeader("USERNAME")
for i := range credentials {
c := credentials[i]
table.AddRow(utils.PtrString(c.Name))
table.AddRow(c.Name)
}
err := table.Display(p)
if err != nil {
Expand Down
10 changes: 5 additions & 5 deletions internal/cmd/observability/credentials/list/list_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ import (
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"github.com/google/uuid"
"github.com/stackitcloud/stackit-sdk-go/services/observability"
observability "github.com/stackitcloud/stackit-sdk-go/services/observability/v1api"
)

var projectIdFlag = globalflags.ProjectIdFlag

type testCtxKey struct{}

var testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo")
var testClient = &observability.APIClient{}
var testClient = &observability.APIClient{DefaultAPI: &observability.DefaultAPIService{}}
var testProjectId = uuid.NewString()
var testInstanceId = uuid.NewString()

Expand Down Expand Up @@ -52,7 +52,7 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
}

func fixtureRequest(mods ...func(request *observability.ApiListCredentialsRequest)) observability.ApiListCredentialsRequest {
request := testClient.ListCredentials(testCtx, testInstanceId, testProjectId)
request := testClient.DefaultAPI.ListCredentials(testCtx, testInstanceId, testProjectId)
for _, mod := range mods {
mod(&request)
}
Expand Down Expand Up @@ -158,10 +158,10 @@ func TestBuildRequest(t *testing.T) {

for _, tt := range tests {
t.Run(tt.description, func(t *testing.T) {
request := buildRequest(testCtx, tt.model, testClient)
request := buildRequest(testCtx, tt.model, testClient.DefaultAPI)

diff := cmp.Diff(request, tt.expectedRequest,
cmp.AllowUnexported(tt.expectedRequest),
cmp.AllowUnexported(tt.expectedRequest, observability.DefaultAPIService{}),
cmpopts.EquateComparable(testCtx),
)
if diff != "" {
Expand Down
14 changes: 7 additions & 7 deletions internal/cmd/observability/grafana/describe/describe.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import (
"github.com/stackitcloud/stackit-cli/internal/pkg/utils"

"github.com/spf13/cobra"
"github.com/stackitcloud/stackit-sdk-go/services/observability"
observability "github.com/stackitcloud/stackit-sdk-go/services/observability/v1api"
)

const (
Expand Down Expand Up @@ -63,12 +63,12 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
}

// Call API
grafanaConfigsReq := buildGetGrafanaConfigRequest(ctx, model, apiClient)
grafanaConfigsReq := buildGetGrafanaConfigRequest(ctx, model, apiClient.DefaultAPI)
grafanaConfigsResp, err := grafanaConfigsReq.Execute()
if err != nil {
return fmt.Errorf("get Grafana configs: %w", err)
}
instanceReq := buildGetInstanceRequest(ctx, model, apiClient)
instanceReq := buildGetInstanceRequest(ctx, model, apiClient.DefaultAPI)
instanceResp, err := instanceReq.Execute()
if err != nil {
return fmt.Errorf("get instance: %w", err)
Expand Down Expand Up @@ -104,18 +104,18 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
return &model, nil
}

func buildGetGrafanaConfigRequest(ctx context.Context, model *inputModel, apiClient *observability.APIClient) observability.ApiGetGrafanaConfigsRequest {
func buildGetGrafanaConfigRequest(ctx context.Context, model *inputModel, apiClient observability.DefaultAPI) observability.ApiGetGrafanaConfigsRequest {
req := apiClient.GetGrafanaConfigs(ctx, model.InstanceId, model.ProjectId)
return req
}

func buildGetInstanceRequest(ctx context.Context, model *inputModel, apiClient *observability.APIClient) observability.ApiGetInstanceRequest {
func buildGetInstanceRequest(ctx context.Context, model *inputModel, apiClient observability.DefaultAPI) observability.ApiGetInstanceRequest {
req := apiClient.GetInstance(ctx, model.InstanceId, model.ProjectId)
return req
}

func outputResult(p *print.Printer, outputFormat string, showPassword bool, grafanaConfigs *observability.GrafanaConfigs, instance *observability.GetInstanceResponse) error {
if instance == nil || instance.Instance == nil {
if instance == nil {
return fmt.Errorf("instance or instance content is nil")
} else if grafanaConfigs == nil {
return fmt.Errorf("grafanaConfigs is nil")
Expand All @@ -130,7 +130,7 @@ func outputResult(p *print.Printer, outputFormat string, showPassword bool, graf
}

table := tables.NewTable()
table.AddRow("GRAFANA DASHBOARD", utils.PtrString(instance.Instance.GrafanaUrl))
table.AddRow("GRAFANA DASHBOARD", instance.Instance.GrafanaUrl)
table.AddSeparator()
table.AddRow("PUBLIC READ ACCESS", utils.PtrString(grafanaConfigs.PublicReadAccess))
table.AddSeparator()
Expand Down
Loading
Loading