feat(vpn): onboarding of connection resource and datasource#1546
Open
rubenhoenle wants to merge 30 commits into
Open
feat(vpn): onboarding of connection resource and datasource#1546rubenhoenle wants to merge 30 commits into
rubenhoenle wants to merge 30 commits into
Conversation
relates to STACKITTPR-551
Co-authored-by: Ruben Hönle <Ruben.Hoenle@digits.schwarz>
8 tasks
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
cgoetz-inovex
requested changes
Jun 29, 2026
| Description: "Whether this connection is enabled.", | ||
| Computed: true, | ||
| }, | ||
| "remote_subnet": schema.ListAttribute{ |
Contributor
There was a problem hiding this comment.
should we use remote_subnets here?
| Computed: true, | ||
| ElementType: types.StringType, | ||
| }, | ||
| "local_subnet": schema.ListAttribute{ |
Contributor
There was a problem hiding this comment.
same as above, plural?
Comment on lines
+828
to
+833
| if !tfutils.IsUndefined(model.LocalSubnet) { | ||
| localSubnets, err := tfutils.ListValueToStringSlice(model.LocalSubnet) | ||
| if err != nil { | ||
| return fmt.Errorf("converting local_subnet: %w", err) | ||
| } | ||
| payload.SetLocalSubnets(localSubnets) |
Contributor
There was a problem hiding this comment.
I suspect an error here:
tf config:
resource "stackit_vpn_gateway" "example-2" {
project_id = var.sna_project_id
display_name = "cg-test-gw-policy"
plan_id = "p500"
routing_type = "POLICY_BASED"
availability_zones = {
tunnel1 = "eu01-1"
tunnel2 = "eu01-2"
}
}
resource "stackit_vpn_connection" "example-2" {
project_id = var.sna_project_id
gateway_id = stackit_vpn_gateway.example-2.gateway_id
display_name = "cg-test-conn-policy"
tunnel1 = {
remote_address = "10.0.0.3"
pre_shared_key = "redacted"
phase1 = {
dh_groups = ["modp2048s256"]
encryption_algorithms = ["aes256gcm16"]
integrity_algorithms = ["sha2_256"]
}
phase2 = {
dh_groups = ["modp2048s256"]
encryption_algorithms = ["aes256gcm16"]
integrity_algorithms = ["sha2_256"]
}
}
tunnel2 = {
remote_address = "10.0.0.3"
pre_shared_key = "redacted"
phase1 = {
dh_groups = ["modp2048s256"]
encryption_algorithms = ["aes256gcm16"]
integrity_algorithms = ["sha2_256"]
}
phase2 = {
dh_groups = ["modp2048s256"]
encryption_algorithms = ["aes256gcm16"]
integrity_algorithms = ["sha2_256"]
}
}
}
results in:
╷
│ Error: Error creating VPN connection
│
│ with stackit_vpn_connection.example-2,
│ on provider.tf line 199, in resource "stackit_vpn_connection" "example-2":
│ 199: resource "stackit_vpn_connection" "example-2" {
│
│ Calling API: 400 Bad Request, status code 400, Body: {"error":{"code":400,"message":"One or more fields are
│ invalid.","status":"BAD_REQUEST","details":[{"reason":"INVALID_FIELD","domain":"vpn.access.stackit.cloud","metadata":{"field":"staticRoutes","validationError":"field
│ must be **excluded"}}]}}**
the plan looks like:
+ static_routes = []
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
continues PR #1487
relates to STACKITTPR-551
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)