Skip to content

Deflake the initialize dial-error proxy test #6264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisJBurns merged 1 commit into from
Aug 10, 2026
Merged

Deflake the initialize dial-error proxy test #6264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions pkg/transport/proxy/transparent/backend_routing_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,9 +820,17 @@ func TestRoundTripDoesNotReplayInitializeOnDialError(t *testing.T) {
req.Header.Set("Content-Type", "application/json")
req.Header.Set("Mcp-Session-Id", clientSessionID)

resp, err := http.DefaultClient.Do(req)
require.NoError(t, err)
_ = resp.Body.Close()
// A dedicated client, not http.DefaultClient: the shared transport pools
// keep-alive connections across the package's parallel tests, and reusing
// one whose proxy has since been closed surfaces here as a transport error.
client := &http.Client{Transport: &http.Transport{DisableKeepAlives: true}}
resp, err := client.Do(req)
// Either outcome is legitimate for a dial failure -- the reverse proxy may
// synthesize a 502, or the connection may fail outright. Neither is what
// this test is about; the assertions below are.
if err == nil {
_ = resp.Body.Close()
}

assert.Zero(t, targetHits.Load(),
"the proxy must not send its own initialize to the target service for an initialize dial error")
Expand Down
Loading