ROX-35308: Wait for scanner before scanning in E2E

[c-du]

Description

After removing the testBegin phase (PR #21387), VulnMgmtSACTest no longer acts as an accidental scanner warm-up buffer. Tests that scan images now start before Scanner has registered with Central, failing with "no image scanners are integrated".

Add ImageService.waitForScannerIntegration() that polls Central's image integration API until a scanner is available (up to 5 minutes), and call it from AdmissionControllerTest and ImageManagementTest setupSpec.

Also fixes ROX-35262.

User-facing documentation

• CHANGELOG.md is updated OR update is not needed
• documentation PR is created and is linked above OR is not needed

Testing and quality

• the change is production ready
• CI results are inspected

Automated testing

• modified existing tests

How I validated my change

Cannot be tested locally -- this is a CI timing issue where Scanner takes 15+ minutes to become ready in GKE E2E test clusters. The change uses the same evaluateWithRetry pattern already used throughout the test suite and calls an existing API (getImageIntegrations). Validation will be done by observing CI results after merge.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 321b2611-ca4f-4e7f-b465-e38604dc60f4

📥 Commits

Reviewing files that changed from the base of the PR and between 23f744e and 3775d95.

📒 Files selected for processing (1)

• qa-tests-backend/src/test/groovy/AdmissionControllerTest.groovy

🚧 Files skipped from review as they are similar to previous changes (1)

• qa-tests-backend/src/test/groovy/AdmissionControllerTest.groovy

---

📝 Walkthrough

Summary by CodeRabbit

• Tests
  • Improved test reliability by waiting for image scanner integration readiness before running admission and image management test suites.
  • Added retry handling and status logging while scanner services become available.

Walkthrough

Adds a retrying helper that waits for a SCANNER-category image integration, then invokes it during setup in AdmissionControllerTest and ImageManagementTest.

Changes

Scanner integration readiness check

Layer / File(s)	Summary
waitForScannerIntegration helper qa-tests-backend/src/main/groovy/services/ImageService.groovy	Imports ImageIntegrationCategory and adds a retry-based helper that filters image integrations for the SCANNER category, asserts availability, and logs the integration name.
Test setup wiring qa-tests-backend/src/test/groovy/AdmissionControllerTest.groovy, qa-tests-backend/src/test/groovy/ImageManagementTest.groovy	Both specifications call ImageService.waitForScannerIntegration() from setupSpec() before continuing setup.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: waiting for scanner integration before E2E scans.
Description check	✅ Passed	The description follows the template closely and includes the required sections, checklist items, and validation notes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cong/server-error

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🚀 Build Images Ready

Images are ready for commit 3775d95. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.12.x-461-g3775d951a5

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.34%. Comparing base (48fb5cf) to head (3775d95).

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #21638      +/-   ##
==========================================
- Coverage   50.39%   50.34%   -0.06%     
==========================================
  Files        2846     2846              
  Lines      218351   218351              
==========================================
- Hits       110034   109924     -110     
- Misses     100336   100424      +88     
- Partials     7981     8003      +22     

Flag	Coverage Δ
go-unit-tests	50.34% <ø> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[c-du]

/test admission-controller-e2e-tests
/test image-management-e2e-tests

[c-du]

/test gke-qa-e2e-tests

[c-du]

/test gke-qa-e2e-tests

[c-du]

/test aks-qa-e2e-tests

[openshift-ci]

@c-du: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ocp-4-22-nongroovy-e2e-tests	3775d95	link	false	/test ocp-4-22-nongroovy-e2e-tests
ci/prow/gke-ui-e2e-tests	3775d95	link	true	/test gke-ui-e2e-tests
ci/prow/gke-upgrade-tests	3775d95	link	false	/test gke-upgrade-tests
ci/prow/gke-nongroovy-e2e-tests	3775d95	link	true	/test gke-nongroovy-e2e-tests
ci/prow/ocp-4-12-nongroovy-e2e-tests	3775d95	link	false	/test ocp-4-12-nongroovy-e2e-tests
ci/prow/ocp-4-21-nongroovy-e2e-tests	3775d95	link	false	/test ocp-4-21-nongroovy-e2e-tests
ci/prow/gke-qa-e2e-tests	3775d95	link	false	/test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.