fix: refinements and bugfixes for new themes - #462
Merged
martin-mfg merged 1 commit intoAug 8, 2026
Merged
Conversation
|
@marcalexiei is attempting to deploy a commit to the martin-mfg's projects Team on Vercel. A member of the Team first needs to authorize it. |
martin-mfg
merged commit Aug 8, 2026
34d0888
into
stats-organization:light-dark-themes
0 of 2 checks passed
Member
|
Wow, I missed a lot of things. 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while reviewing #457.
Dark themes rendered a near-white border.
dark_github/dark_github_repocardhad noborder_colorand fell back to the default theme'se4e2e2.Set GitHub's borders on all four new themes:
d1d9e0light,3d444ddark.Excluding
default/default_repocardbroke the theme picker.Home.tsxinitializes to one of them and treats it as "emit notheme=param", so stage 3 opened with nothing selected and the theme-less URL became unreachable.Paired themes were shown for the wrong card type.
The picker now takes
isRepoCardand lists only the matching variant, hiding duplicates while keeping each card type'sdefaultvisible.Theme README generator only knew the
defaultpair, so the new themes would land in the wrong tables.3 and 4 share a rule, kept duplicated on purpose: which themes to advertise per card type is presentation, not rendering, so it stays out of core's API.
Both copies carry
Keep in synccomments pointing at each other.Dead docs anchor left by the
Responsive Card Theme➡️Light and Dark Moderename.Core gains one export: the
ThemeNametype, replacing the private duplicateThemeNamesincards/types.tsand thekeyof typeof themescasts incolor.tsand the picker.