refactor(frontend): replace the isRepoCard boolean with a card category - #464
Merged
martin-mfg merged 2 commits intoAug 9, 2026
Merged
Conversation
|
@marcalexiei is attempting to deploy a commit to the martin-mfg's projects Team on Vercel. A member of the Team first needs to authorize it. |
marcalexiei
force-pushed
the
card-category
branch
from
August 9, 2026 05:07
d058a00 to
185e5f1
Compare
martin-mfg
merged commit Aug 9, 2026
c7b6e66
into
stats-organization:light-dark-themes
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two places independently hardcoded the same "is this a repo or gist card?" check:
Home.tsx: which theme variant to default toCustomize.tsx: whether to offer "Show Owner?"Both now derive it from one map in
models/CardType.ts:A new card type won't compile until it's categorised, instead of silently falling into the non-repo branch like the boolean did.
It also leaves room for another category, if we ever need one that changes the data a card requires.
Also:
ThemeStagetakescategoryinstead ofisRepoCard.getDefaultTheme/onThemeChangeuse core'sThemeNameinstead ofstring.