Skip to content

feat(core): convert stats card to TypeScript - #466

Open
marcalexiei wants to merge 1 commit into
stats-organization:masterfrom
marcalexiei:core-ts
Open

feat(core): convert stats card to TypeScript#466
marcalexiei wants to merge 1 commit into
stats-organization:masterfrom
marcalexiei:core-ts

Conversation

@marcalexiei

Copy link
Copy Markdown

Another step of #140.

  • src/cards/stats.js + its test ➡️ .ts.
  • Moved createTextNode out of the stats card into common/render.js (next to the other SVG-node builders).
    It was the one card export used by another card (repo).
  • I18n gained a default type param (usable as a bare type),
    and Card/createTextNode accept the possibly-undefined options cards forward.
  • Card tests now use the screen API instead of getByTestId(document.body, …).
    See recommended query entrypoint and cache repeated queries in local variables.
    Also applied on the already-migrated gist/repo tests.

@vercel

vercel Bot commented Aug 9, 2026

Copy link
Copy Markdown

@marcalexiei is attempting to deploy a commit to the martin-mfg's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant