Fix validation of FC22 echoed confirmation fields - #870
Open
Daniiiil1 wants to merge 1 commit into
Open
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Daniil Mordanov.
|
Daniiiil1
marked this pull request as ready for review
August 9, 2026 13:17
Daniiiil1
force-pushed
the
agent/validate-fc22-confirmation
branch
from
August 9, 2026 13:18
0b09c28 to
cb728a4
Compare
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
check_confirmation()Why
The Modbus specification defines the normal Mask Write Register response as an exact echo of the request fields. FC22 previously fell through to the generic one-value case, so a response with the correct function and length could be accepted even when the echoed address or masks differed.
Fixes #868.
Validation
git diff --check./autogen.sh./configure --disable-sharedmake -j4tests/unit-tests.sh—ALL TESTS PASS WITH SUCCESSOne earlier full-suite run hit the pre-existing timing-sensitive 7 ms byte-timeout test on macOS; the FC22 regressions passed in that run, and a clean rerun of the complete integration script passed.