Secure log shipper docs: no public services or IPs#2420
Open
kcmartin wants to merge 4 commits into
Open
Conversation
The log shipper guide told users to keep a [[services]] section on port 8686, which exposed Vector's unauthenticated GraphQL API publicly (reported at community.fly.io/t/14836). Vector pulls logs from the internal stream and needs no inbound access, so remove the service section and deploy with --no-public-ips. Also note how to release IPs on already-exposed deployments. Supersedes #930.
Contributor
Author
|
Tested this end to end against a real deployment (throwaway app in my personal org, destroyed after):
Two things surfaced during testing and were folded into the PR: |
Contributor
Author
|
Hold on merging for now: #1828 raises a related need (the shipper can wedge silently, and a health check was recommended by support). Since this PR removes the public service, the right approach is a top-level |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Log Shipper guide told users to edit
fly.tomland keep a[[services]]section oninternal_port = 8686. That port serves Vector's GraphQL API (including an unauthenticated/playground), so following the docs exposed it publicly. This was reported on the community forum, where Fly staff recommended deploying with--no-public-ips.Vector pulls logs from Fly.io's internal log stream and doesn't need to accept inbound connections, so this:
[[services]]/ port 8686 block from the setup stepsfly deploy --no-public-ipsfly ips list/fly ips release)Supersedes #930 (same fix, but that PR targeted a since-moved file and had gone stale).