Fix Windows modifier overlay visibility - #569
Merged
Merged
Conversation
enaboapps
marked this pull request as ready for review
August 10, 2026 19:34
Greptile SummaryThe modifier overlay now keeps window visibility actions ordered and checks the latest modifier revision before hiding. The previously reported stale-readiness race was exercised in both update and presentation orderings and did not conceal the newer overlay. Confidence Score: 5/5No blocking failure remains. The exercised readiness, modifier-update, and presentation orderings leave the newer nonempty overlay visible. The current revision check prevents an older empty snapshot from issuing a hide after newer modifier input has been published.
What T-Rex did
Reviews (2): Last reviewed commit: "Serialize modifier overlay visibility" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The overlay was created hidden on every platform. On Windows the secondary WebView could remain uninitialized, so it never invoked modifier_overlay_ready; the backend then intentionally suppressed all non-empty presentation without recording a failure.
Impact
Modifier injection is unchanged. Windows users now see the non-focusable, click-through modifier panel, while macOS keeps its existing hidden startup behavior.
Validation
pm run lint
pm test (57 passed)
pm run build
Closes #568