feat(sql-editor): Compare Keys, Sync column, dual-grid highlight - #191
Merged
Conversation
- DataGrid: optional sticky Sync column (rowSync prop, sky styling) - DataMigrateBar: controlled Keys checkboxes, selectedSyncKeys filter, Sync all button, colorful migrate bar, toast when ops but no sync rows - ResultsPanel: selectedSyncKeys state, rowSync on dest grid, restyled compare toolbar with duplicate-key warning and aligned-row legend - USER_GUIDE §6-7: document Keys, Sync column, Sync all - Lib: key-aligned dual-grid insert/delete tint, filterOpsByKeyLabels Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Ensure ATTRIBUTENAME-only compares pad both grids to the same length and highlight missing/extra rows on both panes for synced scrolling. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Replace row-index React state sync with a peer scrollTop bus so fast vertical scrolls keep both compare grids locked without parent re-renders. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Broadcast the hover row index on a peer bus so compare panes highlight the same aligned row without parent re-renders. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_498517d4-15a1-487c-8e76-0990b0995568) |
cursor Bot
pushed a commit
that referenced
this pull request
Aug 7, 2026
Keep Compare UX from this branch (Sync-follows-Ops, Sync scroll, CSV all, Maximize) over the earlier #191 merge on main. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compare data UX for side-by-side SQL Editor results: interactive Keys, destination Sync checkboxes, Sync all / filtered Migrate, and dual-grid insert/delete highlighting (including name-only keys).
Also improves side-by-side grid lock-step UX:
Changes
DataMigrateBar; values follow key selection.scrollSync.register/broadcastapplies peerscrollTopimmediately; virtualization stays rAF-throttled.hoverSyncbus shares the hovered row index across panes (local state only — no parent re-render).Test plan
filterOpsByKeyLabelstsc --noEmitforapps/web