feat: add support for tedious 20 and remove TVP schema workaround#1877
Merged
Conversation
Tedious 19.2.2 fixed the upstream bug where schema names were not included in TVP type declarations (tediousjs/tedious#1730). This removes our SchemaAwareTVP workaround and widens the dependency range to accept both tedious 19.2.2+ and the new tedious 20.x. - Bump tedious dependency to "^19.2.2 || ^20.0.0" - Remove SchemaAwareTVP Object.create() workaround from lib/tedious/request.js - Use tds.TYPES.TVP directly in getTediousType() - Update unit tests to verify tedious natively handles schema in TVP declarations Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🎉 This PR is included in version 12.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for tedious 20.x and removes the
SchemaAwareTVPworkaround that was introduced in #1838.Background
Tedious 19.2.2 (tediousjs/tedious#1730) fixed the upstream bug where schema names were not included in TVP type declarations for
sp_executesql. OurSchemaAwareTVPworkaround (Object.create(tds.TYPES.TVP, ...)) is no longer needed.Tedious 20.0.0 bumps the minimum Node.js version to 22, but is otherwise identical to 19.2.2 in functionality.
Changes
"^19.2.2 || ^20.0.0"SchemaAwareTVPworkaround fromlib/tedious/request.jstds.TYPES.TVPdirectly ingetTediousType()Compatibility
Supersedes #1875 (dependabot).