fix(services): wrap service list responses in an object#39
Open
Ysh204 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the behavior described in tempoxyz/tempo#6576.
services listwas the only command returning a top-level JSON array, while similar commands such askeysandsessions listalready return top-level objects.When
tempo walletis used through MCP integrations, clients such as Claude Code reject the top-level array returned byservices list. This change wraps service list responses in a top-level object, matching the existing pattern used by other list commands.Example output:
{ "services": [ ... ] }This also applies to filtered service list responses (for example,
--search), ensuring all service list outputs share the same shape.Changes
Wrap service list responses in
{ services: [...] }Update the corresponding output schema
Add regression tests covering:
servicesTesting