fix(sessions): replace z.unknown() with typed sessionOutput schema#40
Open
Ysh204 wants to merge 1 commit into
Open
fix(sessions): replace z.unknown() with typed sessionOutput schema#40Ysh204 wants to merge 1 commit into
Ysh204 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently,
sessionsListOutputdefines session records asz.array(z.unknown()), so the generated schema exposed through--schemadoes not describe the structure of session objects.This PR introduces a strongly typed
sessionOutputZod schema matching the objects returned bysessionItem()insrc/commands/sessions.ts.Changes
Add a typed
sessionOutputschema covering:channel_idnetworkoriginsymboldepositspentremainingstatusremaining_secscreated_atlast_used_atReplace
z.array(z.unknown())withz.array(sessionOutput)insessionsListOutputAdd a regression test verifying the generated schema exposes the expected session properties
Testing