Skip to content

fix: correct false continuity example and disambiguate exercise labels - #617

Open
Chessing234 wants to merge 4 commits into
teorth:mainfrom
Chessing234:fix/analysis-statement-fixes
Open

fix: correct false continuity example and disambiguate exercise labels#617
Chessing234 wants to merge 4 commits into
teorth:mainfrom
Chessing234:fix/analysis-statement-fixes

Conversation

@Chessing234

Copy link
Copy Markdown
Contributor

Summary

  • Fix Exercise 11.5.1: 1/x is not continuous on [0,1] — state ¬ ContinuousOn and label both parts.
  • Label both Exercise 11.6.4 integral-test counterexamples as parts (a) and (b).
  • Disambiguate duplicate Verso labels in Exercises 11.3.1 and 3.1.7–3.1.9.

Test plan

  • lake build Analysis succeeds
  • Spot-check Verso anchors for Ex. 11.3.1, 11.5.1, 11.6.4, and 3.1.7–3.1.9

Made with Cursor

Chessing234 and others added 4 commits August 2, 2026 10:04
1/x is not continuous at 0 on the closed interval; state the example as
¬ ContinuousOn and label both parts of Exercise 11.5.1.

Co-authored-by: Cursor <cursoragent@cursor.com>
The second counterexample had no Verso doc comment; mark both as parts
(a) and (b) of Exercise 11.6.4.

Co-authored-by: Cursor <cursoragent@cursor.com>
Split the transitive and antisymmetric majorization lemmas into parts
(a) and (b).

Co-authored-by: Cursor <cursoragent@cursor.com>
Give each set-algebra lemma in Exercises 3.1.7, 3.1.8, and 3.1.9 a
unique (a)/(b)/… Verso anchor.

Co-authored-by: Cursor <cursoragent@cursor.com>
@teorth

teorth commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Thanks — the Exercise 11.5.1 catch here was a real one, and I've landed it separately in #620 with credit to you. ContinuousOn (fun x ↦ 1/x) (Icc 0 1) was genuinely false, so that sorry was unprovable.

I'm closing this PR rather than merging it, because the rest of the changes are docstring disambiguation, and that premise doesn't hold for this repo. Repeated identical exercise docstrings are intentional house style — 12x /-- Exercise 5.4.9 -/, 6x /-- Exercise 3.5.4 -/, and so on — and there's no label or anchor machinery keyed on docstring text (literate.toml sets docstrings_as_text = true, so anchors come from declaration names). That's also why CI was green: there was nothing being fixed. This PR had also gone out of date, with conflicts in Sections 11.3 and 11.5.

If you'd like to propose changing the convention, please open an issue so it can be settled repo-wide.

Statement corrections like the 11.5.1 one — false or mis-hypothesized sorryd goals, in the spirit of #517 — remain very welcome, and are best sent on their own rather than bundled with cosmetic edits.

@teorth teorth closed this Aug 2, 2026
@teorth

teorth commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Reopening — please disregard my previous comment, which was wrong.

I assessed this against a stale checkout of main that was roughly 200 commits behind origin/main. The duplicate-docstring counts I cited (12x /-- Exercise 5.4.9 -/ and so on) were from that stale tree; those had already been fixed on main by #616 and the other label PRs. The label-disambiguation work is an active and accepted cleanup here, not a departure from house style, and this PR is a legitimate continuation of it.

Apologies for the noise.

@teorth teorth reopened this Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants