Skip to content

feat(web): tsc --noEmit typecheck CI gate for the dashboard client (JEF-399) #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thejefflarson merged 2 commits into from
Jul 26, 2026
Merged

feat(web): tsc --noEmit typecheck CI gate for the dashboard client (JEF-399) #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d139eea
feat(web): tsc --noEmit typecheck CI gate for the dashboard client (J…
thejefflarson Jul 26, 2026
5ea03f7
Merge branch 'main' into thejefflarson/jef-399-dashboard-v4-add-a-js-…
thejefflarson Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,12 @@ jobs:
# (the runtime half) runs in the `test` job's `npm run test`. Deps were installed by the
# `npm ci --ignore-scripts` above.
run: npm --prefix engine/web run lint
- name: Typecheck dashboard client (tsc --noEmit)
# JEF-399: eslint's no-unused-vars (JEF-499) catches unused imports; it does not type-check.
# `tsc --noEmit` over engine/web/src (tsconfig.json: checkJs, jsx: react-jsx / preact, offline —
# no `.d.ts` fetch) fails the build on a real type error (e.g. a JSX prop of the wrong type)
# slipping into the bundle. Deps were installed by the `npm ci --ignore-scripts` above.
run: npm --prefix engine/web run typecheck
- name: Format
run: cargo fmt --check
- name: Clippy
Expand Down
Loading