topology2: cavs-sdw: add multiband DRC playback pipeline variant#10969
Draft
singalsu wants to merge 1 commit into
Draft
topology2: cavs-sdw: add multiband DRC playback pipeline variant#10969singalsu wants to merge 1 commit into
singalsu wants to merge 1 commit into
Conversation
Add an alternative BE speaker playback pipeline class mixout-gain-eqiir-eqfir-mbdrc-alh-dai-copier-playback that mirrors the existing mixout-gain-eqiir-eqfir-drc-alh-dai-copier-playback but uses the multiband_drc effect in place of the single-band drc. This lets an SDW amp topology run per-band dynamics processing without duplicating the surrounding gain, EQ IIR and EQ FIR chain. The SDW enhanced speaker playback path in the sdw-amp-generic platform partial is now gated by IncludeByKey.EFX_DRC_COMPONENT with "multiband" and "singleband" branches, both in the pipeline instantiation and in the corresponding route block. The multiband branch selects the new pipeline class and exposes the multiband_drc bytes and switch as "Post Mixer <name> MDRC bytes" / "MDRC switch" so it does not collide with the single-band DRC controls. EFX_DRC_COMPONENT still defaults to "singleband" in efx-default.conf, so existing targets are unaffected. Two development topology targets are added to exercise the new path: sof-mtl-rt713-l0-rt1316-l12-mbdrc and sof-arl-cs42l43-l0-cs35l56-l23-mbdrc, both with EFX_DRC_COMPONENT=multiband. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an alternative BE speaker playback pipeline class mixout-gain-eqiir-eqfir-mbdrc-alh-dai-copier-playback that mirrors the existing mixout-gain-eqiir-eqfir-drc-alh-dai-copier-playback but uses the multiband_drc effect in place of the single-band drc. This lets an SDW amp topology run per-band dynamics processing without duplicating the surrounding gain, EQ IIR and EQ FIR chain.
The SDW enhanced speaker playback path in the sdw-amp-generic platform partial is now gated by IncludeByKey.EFX_DRC_COMPONENT with "multiband" and "singleband" branches, both in the pipeline instantiation and in the corresponding route block. The multiband branch selects the new pipeline class and exposes the multiband_drc bytes and switch as "Post Mixer MDRC bytes" / "MDRC switch" so it does not collide with the single-band DRC controls. EFX_DRC_COMPONENT still defaults to "singleband" in efx-default.conf, so existing targets are unaffected.
Two development topology targets are added to exercise the new path: sof-mtl-rt713-l0-rt1316-l12-mbdrc and
sof-arl-cs42l43-l0-cs35l56-l23-mbdrc, both with
EFX_DRC_COMPONENT=multiband.