audio: phase vocoder: fix module name mismatch with TOML manifest#10973
Merged
Conversation
The LLEXT manifest declared the module name as "PHASE_VOCODER", which rimage truncates to "PHASE_VO" (SOF_MAN_MOD_NAME_LEN is 8), while phase_vocoder.toml uses "PHASEVOC". The names do not match, so rimage fails to package modular builds with the error "Module PHASE_VO not found in TOML." on platforms that build the component as loadable module (e.g. PTL). Use "PHASEVOC" in the manifest to match the TOML entry. Fixes #e9bfc2f6b402 Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
abonislawski
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Fixes e9bfc2f Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a packaging failure for modular builds of the Phase Vocoder component by aligning the LLEXT module manifest name with the module name declared in the component’s TOML manifest, avoiding rimage’s 8-byte module-name truncation mismatch.
Changes:
- Update the Phase Vocoder LLEXT module manifest name to
"PHASEVOC"so it matchesphase_vocoder.toml.
lgirdwood
approved these changes
Jul 3, 2026
|
One failed test not related to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LLEXT manifest declared the module name as "PHASE_VOCODER", which rimage truncates to "PHASE_VO" (SOF_MAN_MOD_NAME_LEN is 8), while phase_vocoder.toml uses "PHASEVOC". The names do not match, so rimage fails to package modular builds with the error "Module PHASE_VO not found in TOML." on platforms that build the component as loadable module (e.g. PTL).
Use "PHASEVOC" in the manifest to match the TOML entry.
Fixes #10541