Create the node metrics service for Calico - #5134
Open
caseydavenport wants to merge 2 commits into
Open
Conversation
The port configured in FelixConfiguration applies to Calico as well as Enterprise.
Calico gets a service carrying only Felix's port, and only once Felix metrics are enabled. Enterprise keeps its reporter and BGP ports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The operator already creates metrics Services for Typha and kube-controllers, but not for Felix, so Calico users following the component metrics guide have to hand-roll one. This renders the existing
calico-node-metricsService for Calico too, carrying only Felix's port, and removes it again if Felix metrics are turned back off. Enterprise keeps its reporter and BGP ports, unchanged.Also fixes the Felix metrics port being read out of FelixConfiguration only for Enterprise. Nothing consumed it in a Calico install before this change, but with the Service rendered it would have pointed at the default port no matter what the user configured.
Windows is not covered here. The Windows metrics Service has never carried Felix's port, even in Enterprise, and getting one to work needs a firewall rule, so it wants its own change.
Related: projectcalico/calico#10755
Release Note
For PR author
make gen-filesmake gen-versions