Correct the Variant doc comment on Installation - #5135
Merged
caseydavenport merged 1 commit intoAug 4, 2026
Conversation
There is no CRD default on the field, and the operator now defaults it to the variant it booted as rather than always Calico.
caseydavenport
added
docs-not-required
release-note-not-required
and removed
release-note-required
docs-pr-required
labels
Brian-McM
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variant field on Installation documents itself as defaulting to Calico, which reads like an API guarantee. There is no CRD-level default on the field, and the operator now fills in whichever variant it booted as, so the comment is wrong either way.
Deliberately not adding a schema default to fix it: the overlay merge treats the empty value as "not specified", so a default would be written into the overlay object too and would win the merge, silently changing the variant for Enterprise clusters that use an overlay for something unrelated. Defaults can't be scoped to a single object name.
CORE-13244