Fix jemalloc builds for Windows MSVC targets - #173
Conversation
|
Welcome @han1548772930! It looks like this is your first PR to tikv/jemallocator 🎉 |
📝 WalkthroughWalkthroughThe build script now uses Windows-specific target mappings, preserves Windows build output directories, and emits platform-specific linker names and search paths. ChangesWindows jemalloc build handling
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff: DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Then build:
For jemalloc profiling:
Tested with the
x86_64-pc-windows-msvcRust target.