Fix the build: pin nightly-2022-11-02, repair CI, fix onboarding docs#41
Open
jenish-25 wants to merge 5 commits into
Open
Fix the build: pin nightly-2022-11-02, repair CI, fix onboarding docs#41jenish-25 wants to merge 5 commits into
jenish-25 wants to merge 5 commits into
Conversation
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The project currently fails to build for everyone on a modern toolchain
(see #35, #36, #37). This PR revives the build and fixes developer onboarding.
Root cause: the crate relies on nightly-only feature gates
(
#![feature(async_closure)],#![feature(mutex_unlock)]intinydancer/src/main.rs) and locked, era-specific dependencies, but nothing pinsa compatible toolchain. A current nightly can't compile the locked
proc-macro2 1.0.51(unknown feature proc_macro_span_shrink) and has removedmutex_unlockentirely, so the build dies before it starts. CI made this worseby installing no system dependencies and using archived
actions-rs/*actions.Changes
rust-toolchain.tomlpinningnightly-2022-11-02— the same nightly thediet-rpc-validatorSolana fork (which this crate builds against) uses in itsci/rust-version.sh.rustupnow selects the correct compiler automatically..github/workflows/crates.yml: install the required system deps(
protobuf-compiler,libudev-dev,libssl-dev,clang,cmake, …), pin thetoolchain, move to
ubuntu-22.04, modernize toactions/checkout@v4+dtolnay/rust-toolchain, fix the malformedbranch:trigger (→branches:),add
pull_request/workflow_dispatch, and disable the crates.io publish job(a maintainer-only action).
cargo installcommand (the oldhalf-baked-clientrepo nowredirects), document the pinned toolchain, and list the Linux system deps.
tinydancerto0.0.9.Verification
Built cleanly on GitHub Actions (Ubuntu,
nightly-2022-11-02):proc-macro2): https://github.com/jenish-25/tinydancer/actions/runs/28919854760Closes #35, #36, #37.