Skip to content

Fix the build: pin nightly-2022-11-02, repair CI, fix onboarding docs#41

Open
jenish-25 wants to merge 5 commits into
tinydancer-io:masterfrom
jenish-25:fix/build-and-onboarding
Open

Fix the build: pin nightly-2022-11-02, repair CI, fix onboarding docs#41
jenish-25 wants to merge 5 commits into
tinydancer-io:masterfrom
jenish-25:fix/build-and-onboarding

Conversation

@jenish-25

Copy link
Copy Markdown

Summary

The project currently fails to build for everyone on a modern toolchain
(see #35, #36, #37). This PR revives the build and fixes developer onboarding.

Root cause: the crate relies on nightly-only feature gates
(#![feature(async_closure)], #![feature(mutex_unlock)] in
tinydancer/src/main.rs) and locked, era-specific dependencies, but nothing pins
a compatible toolchain. A current nightly can't compile the locked
proc-macro2 1.0.51 (unknown feature proc_macro_span_shrink) and has removed
mutex_unlock entirely, so the build dies before it starts. CI made this worse
by installing no system dependencies and using archived actions-rs/* actions.

Changes

  • Add rust-toolchain.toml pinning nightly-2022-11-02 — the same nightly the
    diet-rpc-validator Solana fork (which this crate builds against) uses in its
    ci/rust-version.sh. rustup now selects the correct compiler automatically.
  • Repair .github/workflows/crates.yml: install the required system deps
    (protobuf-compiler, libudev-dev, libssl-dev, clang, cmake, …), pin the
    toolchain, move to ubuntu-22.04, modernize to actions/checkout@v4 +
    dtolnay/rust-toolchain, fix the malformed branch: trigger (→ branches:),
    add pull_request / workflow_dispatch, and disable the crates.io publish job
    (a maintainer-only action).
  • README: fix the cargo install command (the old half-baked-client repo now
    redirects), document the pinned toolchain, and list the Linux system deps.
  • Bump tinydancer to 0.0.9.

Verification

Built cleanly on GitHub Actions (Ubuntu, nightly-2022-11-02):

Closes #35, #36, #37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build fails on both v0 and v1

1 participant