Skip to content

Formalize action constants and remove Uint from codec interfaces#2

Merged
cdvelop merged 2 commits into
mainfrom
named-action-constants-remove-uint-17389871191021151875
Jul 8, 2026
Merged

Formalize action constants and remove Uint from codec interfaces#2
cdvelop merged 2 commits into
mainfrom
named-action-constants-remove-uint-17389871191021151875

Conversation

@cdvelop

@cdvelop cdvelop commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Executed the implementation plan in docs/PLAN.md:

  1. Formalized CRUD action bytes as plain byte constants (ActionCreate, ActionRead, ActionUpdate, ActionDelete) to serve as a single source of truth.
  2. Replaced all magic literals ('c', 'u', 'd') in the validation logic and documentation.
  3. Simplified the codec contract by removing the vestigial Uint methods from FieldWriter and FieldReader, aligning with the project's 64-bit-only design.
  4. Updated the mock implementations and test suite to reflect these changes.
  5. Updated all relevant documentation files.

PR created automatically by Jules for task 17389871191021151875 started by @cdvelop

- Added ActionCreate, ActionRead, ActionUpdate, ActionDelete byte constants in field.go.
- Replaced magic action literals in ValidateFields and its documentation.
- Removed Uint from FieldWriter and FieldReader interfaces in codec.go.
- Updated tests and documentation (README.md, docs/API_FIELD.md, docs/API_CODEC.md, docs/WHY_64BIT_ONLY.md).
- Added value-pinning contract tests for action constants.

Co-authored-by: cdvelop <44058491+cdvelop@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cdvelop cdvelop merged commit 2372182 into main Jul 8, 2026
@cdvelop cdvelop deleted the named-action-constants-remove-uint-17389871191021151875 branch July 8, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant