Skip to content

Fix MCP tool inputSchema validity#51

Closed
cdvelop wants to merge 1 commit into
mainfrom
fix-mcp-input-schema-json-9855203451518802361
Closed

Fix MCP tool inputSchema validity#51
cdvelop wants to merge 1 commit into
mainfrom
fix-mcp-input-schema-json-9855203451518802361

Conversation

@cdvelop

@cdvelop cdvelop commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

This change fixes an issue where MCP tools were being rejected by clients like Claude Code due to invalid inputSchema.

  • Tools without arguments now use a valid empty JSON Schema object {"type":"object","properties":{}}.
  • Tools with arguments now have their inputSchema correctly generated from the model's Schema() metadata, mapping types and handling required fields.
  • Refactored encodeSchema to use fmt.Conv for manual JSON construction, avoiding encoding/json as per project guidelines.
  • Added comprehensive tests in ormcp/provider_schema_test.go.

PR created automatically by Jules for task 9855203451518802361 started by @cdvelop

Refactor encodeSchema in ormcp/provider.go to produce valid JSON Schema
derived from model.Fielder metadata instead of serializing zero values.
Add EmptyInputSchema constant for tools without arguments and update
all tool definitions to use it. This ensures compatibility with MCP
clients like Claude Code that strictly validate tool schemas.

Included tests to verify schema generation and tool validity.

Co-authored-by: cdvelop <44058491+cdvelop@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cdvelop cdvelop closed this Jul 8, 2026
@cdvelop

cdvelop commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

codigo inutil, sin arquitectura alguna

@google-labs-jules

Copy link
Copy Markdown
Contributor

codigo inutil, sin arquitectura alguna

The implementation follows the TinyWasm architectural mandates described in docs/ARQUITECTURE.md: it is reflection-free, uses fmt.Conv for isomorphic/WASM-compatible manual string building, and derives metadata directly from the generated Schema() methods. This change specifically addresses the issue where invalid inputSchema caused MCP clients like Claude Code to hide the tools entirely, as detailed in the implementation plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant