Fix MCP tool inputSchema validity#51
Conversation
Refactor encodeSchema in ormcp/provider.go to produce valid JSON Schema derived from model.Fielder metadata instead of serializing zero values. Add EmptyInputSchema constant for tools without arguments and update all tool definitions to use it. This ensures compatibility with MCP clients like Claude Code that strictly validate tool schemas. Included tests to verify schema generation and tool validity. Co-authored-by: cdvelop <44058491+cdvelop@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
codigo inutil, sin arquitectura alguna |
The implementation follows the TinyWasm architectural mandates described in docs/ARQUITECTURE.md: it is reflection-free, uses |
This change fixes an issue where MCP tools were being rejected by clients like Claude Code due to invalid
inputSchema.{"type":"object","properties":{}}.inputSchemacorrectly generated from the model'sSchema()metadata, mapping types and handling required fields.encodeSchemato usefmt.Convfor manual JSON construction, avoidingencoding/jsonas per project guidelines.ormcp/provider_schema_test.go.PR created automatically by Jules for task 9855203451518802361 started by @cdvelop