feat: add S3 storage, locking, concatenation, and JSON metadata serialization - #111
Merged
Conversation
|
coverage: 95.768% (-0.7%) from 96.487% — feature/s3-storage-support into master |
…d achieve >95% test coverage
…torage components
…ls JSON methods, and update documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces full S3-compatible object storage support (
S3StorageService), distributed locking (S3LockingService), dual-strategy concatenation (S3ConcatenationService), optional JSON metadata serialization, and developer instructions for Testcontainers + MinIO (supporting Docker and Podman).Key Highlights
S3StorageService: Always-multipart upload strategy matchingtusd, incomplete part buffering (.partobjects for sub-5MB chunks), dynamic part scaling up to 5GB, checksum deduplication, and zero-byte upload support.S3LockingService: S3 conditional writes (If-None-Match: "*"), heartbeat daemon lease renewals, cross-pod lock contention resolution (.stopsignal files), enabling multi-replica container deployments without external Redis/database lockers.S3ConcatenationService: Fast server-side copy (UploadPartCopy) for partial uploads >= 5 MB and streaming re-upload fallback for sub-5MB chunks..withJsonSerialization()builder option forTusFileUploadServiceandDiskStorageService.ITS3StorageService,ITS3LockingService,ITS3TusFileUploadService, andITS3RufhProtocolintegration test suites running against MinIO usingTestUtils(supporting Docker & Podman). Added developer documentation indocs/S3_STORAGE.md.Verification