Conversation
What was broken URL First2Finish challenges could render the Iterative Review tab without the logged-in reviewer's action when the row selected for display was keyed differently from the canonical submission. Root cause The F2F limiter only matched row ids and review submission ids, but URL submissions can carry the canonical submission id in legacySubmissionId. Duplicate rows for the same submission also preferred completed reviews even when the pending row belonged to the current reviewer. What was changed Iterative-review row limiting now matches all known submission aliases, including legacySubmissionId. Duplicate row selection now adds priority for rows assigned to the current reviewer's resource ids before rendering the action column. Any added/updated tests Added iterative-review filtering coverage for URL legacy submission id matching and current-reviewer duplicate row priority. Ran the focused Review spec successfully; the full platform-ui test command still fails on unrelated baseline wallet-admin module-resolution failures and existing Work challenge launch expectations.
What was broken After an active development challenge was changed from a scheduled launch to immediately, the save could still show the non-Design phase-shortening error even though the immediate schedule had already persisted. Root cause (if identifiable) Immediate saves can persist phase durations with leftover seconds because the backend records current seconds and milliseconds. The Work app converted API durations from seconds to whole minutes by truncating, so the next save could send a phase up to 59 seconds shorter and trigger the backend shortening guard. What was changed Round partial API phase durations up to the next whole minute when hydrating the challenge editor form. This preserves or slightly extends the saved phase window instead of submitting a shorter duration on the next save. Any added/updated tests Added a challenge editor schedule mapping regression test for API phase durations with leftover seconds.
What was broken The desktop Achievements card used less bottom padding than top padding, leaving the bottom of the card visually tighter than the top. Root cause (if identifiable) MemberTCAchievements.module.scss set desktop padding to $sp-8 $sp-8 $sp-2, so the top and sides used the standard card spacing while the bottom used a smaller spacing token. What was changed Changed the desktop Achievements card padding to use $sp-8 on all sides while preserving the existing mobile override. Any added/updated tests Added a MemberTCAchievements style regression test that asserts the desktop card uses even padding.
What was broken Member profile left-column toggles for the bio and awards used larger 16px text while nearby add-link actions used the smaller 14px link button size. The collapsed bio preview could also leave the ellipsis on a short extra wrapped line. Root cause (if identifiable) The bio and awards toggles use custom button styles with a hard-coded 16px font size instead of matching the shared add-link typography. The bio truncation threshold was long enough to include an extra sparse line before the See More control. What was changed Updated the bio and awards toggle font size to the 14px spacing token used by the shared link buttons. Shortened the collapsed member bio preview length so the ellipsis appears earlier in the left-column layout and updated the helper documentation. Any added/updated tests Updated the existing getTruncatedBio expectations and added a regression case for screenshot-style profile bio previews.
PM-5518: Align member profile link sizing
PM-5519: Fix achievements card padding
PM-5516: Restore URL F2F iterative review actions
PM-5447: Preserve immediate phase durations
…ase-media Fix default env for showcase media
jmgasper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-5245
https://topcoder.atlassian.net/browse/PM-5519
https://topcoder.atlassian.net/browse/PM-5518
https://topcoder.atlassian.net/browse/PM-5566