Skip to content

PM-5625 - remove skipping token validation in non-production environments #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vas3a wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

PM-5625 - remove skipping token validation in non-production environments #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/shared/modules/global/jwt.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,11 +231,6 @@ export class JwtService implements OnModuleInit {

const payload = decoded.payload as JwtPayloadRecord;

if (process.env.NODE_ENV !== 'production') {
// TODO (security): CRITICAL - JWT signature verification is skipped entirely in non-production (NODE_ENV !== 'production'). Any token with a valid structure will be accepted. This must never reach a publicly accessible environment.
return payload;
}

const issuer = this.resolveIssuer(payload);
const keyId =
decoded.header && typeof decoded.header.kid === 'string'
Expand Down
Loading