Create en_ud.json - #655
Conversation
WalkthroughAdded a new English upside-down locale file containing FirstPerson UI strings, option labels and tooltips, keybind and category names, and modmenu descriptions. ChangesLocalization
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8)src/main/resources/assets/firstperson/lang/en_ud.jsonTraceback (most recent call last): Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/resources/assets/firstperson/lang/en_ud.json`:
- Line 23: Correct the value for the translation key
text.firstperson.option.firstperson.vanillaHandMode in en_ud.json by removing
the extra leading V and placing the transformed V at the end, preserving the
intended upside-down “Vanilla Hands Mode” translation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fa1139c1-152b-47be-bb66-3328a8a7f01b
📒 Files selected for processing (1)
src/main/resources/assets/firstperson/lang/en_ud.json
| "text.firstperson.option.firstperson.sitXOffset.tooltip": "ƃuᴉʇʇᴉs ǝlᴉɥʍ ɥʇɹoɟ puɐ ʞɔɐq ɐɹǝɯɐɔ ǝɥʇ oʇ ǝʌᴉʇɐlǝɹ ʎpoq ǝɥʇ sǝʌoW", | ||
| "text.firstperson.option.firstperson.renderStuckFeatures": "sƃuᴉʇS ⅋ sʍoɹɹ∀ ɹǝpuǝɹ", | ||
| "text.firstperson.option.firstperson.renderStuckFeatures.tooltip": "uosɹǝd ʇsɹᴉɟ uᴉ sǝɹnʇɐǝɟ pǝppoɯ ɹǝɥʇo ɹo sƃuᴉʇs ǝǝq 'sʍoɹɹɐ sʍoɥS", | ||
| "text.firstperson.option.firstperson.vanillaHandMode": "VǝpoW spuɐH ɐllᴉuɐ", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Fix the upside-down “Vanilla Hands Mode” translation.
Line 23 has an extra leading V; the transformed V should appear at the end. The current PR value is VǝpoW spuɐH ɐllᴉuɐ. (raw.githubusercontent.com)
Proposed fix
- "text.firstperson.option.firstperson.vanillaHandMode": "VǝpoW spuɐH ɐllᴉuɐ",
+ "text.firstperson.option.firstperson.vanillaHandMode": "ǝpoW spuɐH ɐllᴉuɐΛ",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "text.firstperson.option.firstperson.vanillaHandMode": "VǝpoW spuɐH ɐllᴉuɐ", | |
| "text.firstperson.option.firstperson.vanillaHandMode": "ǝpoW spuɐH ɐllᴉuɐΛ", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/main/resources/assets/firstperson/lang/en_ud.json` at line 23, Correct
the value for the translation key
text.firstperson.option.firstperson.vanillaHandMode in en_ud.json by removing
the extra leading V and placing the transformed V at the end, preserving the
intended upside-down “Vanilla Hands Mode” translation.



No description provided.