Skip to content

Create en_ud.json - #655

Open
Fhilips613 wants to merge 1 commit into
tr7zw:mainfrom
Fhilips613:main
Open

Create en_ud.json#655
Fhilips613 wants to merge 1 commit into
tr7zw:mainfrom
Fhilips613:main

Conversation

@Fhilips613

Copy link
Copy Markdown

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Added a new English upside-down locale file containing FirstPerson UI strings, option labels and tooltips, keybind and category names, and modmenu descriptions.

Changes

Localization

Layer / File(s) Summary
Add upside-down English translations
src/main/resources/assets/firstperson/lang/en_ud.json
Adds locale mappings for titles, tabs, options, tooltips, keybinds, categories, and modmenu text.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided, so there is no meaningful summary to evaluate. Add a brief description of what en_ud.json contains and why the locale file is being created.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the new en_ud.json file being added.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
src/main/resources/assets/firstperson/lang/en_ud.json

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/main/resources/assets/firstperson/lang/en_ud.json`:
- Line 23: Correct the value for the translation key
text.firstperson.option.firstperson.vanillaHandMode in en_ud.json by removing
the extra leading V and placing the transformed V at the end, preserving the
intended upside-down “Vanilla Hands Mode” translation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fa1139c1-152b-47be-bb66-3328a8a7f01b

📥 Commits

Reviewing files that changed from the base of the PR and between eef8f91 and a582adb.

📒 Files selected for processing (1)
  • src/main/resources/assets/firstperson/lang/en_ud.json

"text.firstperson.option.firstperson.sitXOffset.tooltip": "ƃuᴉʇʇᴉs ǝlᴉɥʍ ɥʇɹoɟ puɐ ʞɔɐq ɐɹǝɯɐɔ ǝɥʇ oʇ ǝʌᴉʇɐlǝɹ ʎpoq ǝɥʇ sǝʌoW",
"text.firstperson.option.firstperson.renderStuckFeatures": "sƃuᴉʇS ⅋ sʍoɹɹ∀ ɹǝpuǝɹ",
"text.firstperson.option.firstperson.renderStuckFeatures.tooltip": "uosɹǝd ʇsɹᴉɟ uᴉ sǝɹnʇɐǝɟ pǝppoɯ ɹǝɥʇo ɹo sƃuᴉʇs ǝǝq 'sʍoɹɹɐ sʍoɥS",
"text.firstperson.option.firstperson.vanillaHandMode": "VǝpoW spuɐH ɐllᴉuɐ",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Fix the upside-down “Vanilla Hands Mode” translation.

Line 23 has an extra leading V; the transformed V should appear at the end. The current PR value is VǝpoW spuɐH ɐllᴉuɐ. (raw.githubusercontent.com)

Proposed fix
-    "text.firstperson.option.firstperson.vanillaHandMode": "VǝpoW spuɐH ɐllᴉuɐ",
+    "text.firstperson.option.firstperson.vanillaHandMode": "ǝpoW spuɐH ɐllᴉuɐΛ",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"text.firstperson.option.firstperson.vanillaHandMode": "VǝpoW spuɐH ɐllᴉuɐ",
"text.firstperson.option.firstperson.vanillaHandMode": "ǝpoW spuɐH ɐllᴉuɐΛ",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/main/resources/assets/firstperson/lang/en_ud.json` at line 23, Correct
the value for the translation key
text.firstperson.option.firstperson.vanillaHandMode in en_ud.json by removing
the extra leading V and placing the transformed V at the end, preserving the
intended upside-down “Vanilla Hands Mode” translation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant