Fix memory lease issues with Pebble#147
Merged
Merged
Conversation
Pebble requires any allocated memory to be used before the resources are closed. This wasn't strictly done before and could cause non-deterministic behaviour depending on the GC. Also deleted binary that was accidentally checked in.
AlCutter
approved these changes
Jul 22, 2026
mhutchinson
force-pushed
the
fix/mem-usage
branch
from
July 22, 2026 11:59
5110cdd to
59dc895
Compare
AlCutter
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pebble requires any allocated memory to be used before the resources are
closed. This wasn't strictly done before and could cause
non-deterministic behaviour depending on the GC.
Also deleted binary that was accidentally checked in.