ci: ensure portable jextract code, to match deploy release build#173
ci: ensure portable jextract code, to match deploy release build#173Marcono1234 wants to merge 5 commits into
Conversation
| java-version: [23, 24, 25] | ||
| # To match the release build workflow, use the jextract generated code for Linux and | ||
| # verify that it is portable | ||
| use-jextract-linux-code: [true] |
There was a problem hiding this comment.
Side note: GitHub currently implicitly includes the matrix arguments in the job name, e.g. "Test package (windows-latest, 25, true)". Is that ok or would you prefer if name was more descriptive?
|
@ObserverOfTime, do you think this PR here is useful? The code duplication is not ideal though; maybe it could be reduced by using for example a reusable workflow, but I am not sure. |
|
I'll look into it if #172 wasn't enough. |
|
To me it looks like the fix in #172 was enough (thanks for that!). Both for my local Windows build and CI it works with jtreesitter 0.26.1. This PR here was meant rather as a way to detect similar issues in the future in advance. An alternative might be to perform this check somehow as part of |
Relates to #171 and #172
Changes the
ci.ymlworkflow so that it is more similar to thedeploy.ymlworkflow, by running jextract on Linux and then using that code on the other platforms (Windows and macOS).The changes have this effect:
(to match what
deploy.ymlis doing; this also surfaces the failures of Version 0.26.0 does not work on Windows due to incompatible jextract code #171)(this is mainly to ensure that local builds on these platforms work, in case users build the project themselves instead of using the release versions)
What do you think?