feat: color Review tab pill by workspace change state - #231
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Screenshot QA covers all three pill colors against a real jj repo via NAPI.
- Yellow opens Review once so
changedFilespopulates the count - Grey stays on Code to prove status-only
commits_aheadpath - Red uses the existing rebase-conflict recipe from
review-conflict-card
There was a problem hiding this comment.
Lift committed file list to the parent so the grey pill number can be file-based after Review mounts.
- Uncommitted still flows through existing
onChangedFilesChange - Effect fires whenever
committedFilesupdates fromgetWorkspaceDiff onCommittedFilesChange
There was a problem hiding this comment.
Pure helper keeps pill tone/count policy out of JSX and unit-testable.
- Priority is conflict → uncommitted → committed-only, matching the product rule
- Count waits for a real number so
has_changesalone cannot flash a fake1before Review loads files getReviewTabPill
There was a problem hiding this comment.
Wire the helper to status + file lists so the pill works on Code (committed/conflict) and updates after Review loads WC files.
- Yellow uses
changedFiles/has_changes; grey can appear fromcommits_ahead_of_targetwithout opening Review onCommittedFilesChangeupgrades grey count from commits-ahead to committed file count once the viewer loadsreviewTabPillmemo
Ziinc
marked this pull request as ready for review
August 8, 2026 22:18
Red for conflicts, yellow for uncommitted working-copy changes, and grey when only committed changes remain. Lift committed file counts from the diff viewer so the badge stays accurate. Co-authored-by: Ziinc <Ziinc@users.noreply.github.com>
Cover yellow (uncommitted), grey (committed-only), and red (conflict) pill states in the screenshot harness, and fix lint on the new helpers. Co-authored-by: Ziinc <Ziinc@users.noreply.github.com>
Use bg-destructive/20 text-destructive so the conflict badge stays on the destructive token without the solid filled red. Co-authored-by: Ziinc <Ziinc@users.noreply.github.com>
Keep the merged imports from main's review-change-count query and the Review pill tone helper. Co-authored-by: Ziinc <Ziinc@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/review-tab-pill-colors-ed8a
branch
from
August 8, 2026 22:25
687b677 to
2375d31
Compare
Co-authored-by: Ziinc <Ziinc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bg-destructive/20 text-destructive— standard destructive colour at lower intensity.getReviewTabPill; the number reuses main’s stable unique WC + committed count from#229.main(includes#229review-tab count fix).Test plan
getReviewTabPilltone/count priorityShowWorkspace.review-pill.test.tsxasserts yellow / grey / soft-destructive classesYellow uncommitted pill
Grey committed-only pill
Soft destructive conflict pill
To show artifacts inline, enable in settings.