Skip to content

gha: Remove pull_request_target flow#303

Merged
Jakob-Naucke merged 1 commit into
trusted-execution-clusters:mainfrom
Jakob-Naucke:fix-concurrent-gha
Jul 1, 2026
Merged

gha: Remove pull_request_target flow#303
Jakob-Naucke merged 1 commit into
trusted-execution-clusters:mainfrom
Jakob-Naucke:fix-concurrent-gha

Conversation

@Jakob-Naucke

@Jakob-Naucke Jakob-Naucke commented Jul 1, 2026

Copy link
Copy Markdown
Member

was added in error, thinking that the labeled event could not apply to pull_request when it can. This lead to failures because checkout is not enabled by default on pull_request_target for security reasons, as happened in #302.

Summary by Sourcery

CI:

  • Update the integration tests GitHub Actions workflow to trigger on labeled pull_request events alongside the standard pull_request event types.

@sourcery-ai

sourcery-ai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Consolidates the GitHub Actions integration test workflow to trigger on the pull_request event (including labeled) and removes the insecure/incorrect pull_request_target flow that caused checkout failures.

File-Level Changes

Change Details Files
Update integration test workflow triggers to use only pull_request with explicit event types including labeled.
  • Remove the pull_request_target event trigger from the integration test workflow.
  • Configure the pull_request trigger to use explicit types: opened, synchronize, reopened, and labeled.
  • Add a clarifying comment documenting that labeled is used for ok-to-test labeling.
  • Keep the workflow restricted to the main branch for pull requests.
.github/workflows/integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread .github/workflows/integration-tests.yml
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alicefr, Jakob-Naucke

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

was added in error, thinking that the `labeled` event could not apply
to `pull_request` when it can. This lead to failures because checkout
is not enabled by default on `pull_request_target` for security
reasons, as happened in trusted-execution-clusters#302.

Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
@openshift-ci openshift-ci Bot removed the lgtm label Jul 1, 2026
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@Jakob-Naucke

Copy link
Copy Markdown
Member Author

took a no-op push because old workflow is still active from the label

@Jakob-Naucke Jakob-Naucke merged commit bbd1046 into trusted-execution-clusters:main Jul 1, 2026
10 checks passed
@Jakob-Naucke Jakob-Naucke deleted the fix-concurrent-gha branch July 1, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants