Skip to content

website: parse playground snippets once per run #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davydog187 merged 1 commit into from
Jul 27, 2026
Merged

website: parse playground snippets once per run #402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions website/lib/website/lua_sandbox.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,13 +212,16 @@ defmodule Website.LuaSandbox do
end)

try do
bytecode =
# Parse once and reuse the chunk for both the bytecode pane and the
# evaluation itself. A parse failure falls through to eval!/2 on the
# source so the error path still raises the usual CompilerException.
{bytecode, runnable} =
case Lua.parse_chunk(source) do
{:ok, %Lua.Chunk{prototype: proto}} -> disassemble(proto)
_ -> []
{:ok, %Lua.Chunk{prototype: proto} = chunk} -> {disassemble(proto), chunk}
_ -> {[], source}
end

{results, _lua} = Lua.eval!(lua, source)
{results, _lua} = Lua.eval!(lua, runnable)

%{
status: :ok,
Expand Down
Loading