FIX #86#87
Open
hrotkogabor wants to merge 1 commit into
Open
Conversation
Craig-At-Ollie
approved these changes
Jul 16, 2026
Craig-At-Ollie
left a comment
There was a problem hiding this comment.
I ran into this same build failure on Xubuntu 26 (Xfce 4.20) with a recent GCC. Two functions in common/ have prototype/definition mismatches that newer GCC now rejects as hard errors rather than warnings.
Both compiled fine historically because in C89/C99/C17, an empty parameter list () means "unspecified arguments" - the compiler doesn't check arity against it. But GCC's newer default C standard (C23) changed this: () now means "takes zero arguments," equivalent to (void). So these two spots go from silently-fine to a hard compile error: too many arguments to function / conflicting types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.