Skip to content

Ruff formatted available radial space for #4383#4423

Open
jmorris-uk wants to merge 1 commit into
mainfrom
4383-expression-value-unused
Open

Ruff formatted available radial space for #4383#4423
jmorris-uk wants to merge 1 commit into
mainfrom
4383-expression-value-unused

Conversation

@jmorris-uk

Copy link
Copy Markdown
Contributor

Description

Minor formatting change to remove Pylance warning.

@jmorris-uk jmorris-uk requested a review from a team as a code owner July 8, 2026 12:37
@jmorris-uk jmorris-uk linked an issue Jul 8, 2026 that may be closed by this pull request
@jmorris-uk jmorris-uk requested a review from clmould July 8, 2026 12:37

@timothy-nunn timothy-nunn Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to clarify to anyone reviewing what was going on here. Before this change the calculation for available radial space was essentially:

data.build.available_radial_space = (
    data.stellarator.r_coil_minor * data.stellarator.f_coil_shape
    - data.physics.rminor
)

This bit of code was not doing anything and it was not changing the available_radial_space.

+data.stellarator_config.stella_config_derivative_min_lcfs_coils_dist * (
    data.physics.rminor
    - data.stellarator.f_st_rmajor * data.stellarator_config.stella_config_rminor_ref
)

It would be good for someone with stellarator knowledge to confirm that this was a mistake @jjwalkowiak @grmtrkngtn

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.85%. Comparing base (e9d8681) to head (e219e5d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4423      +/-   ##
==========================================
- Coverage   48.85%   48.85%   -0.01%     
==========================================
  Files         151      151              
  Lines       29390    29389       -1     
==========================================
- Hits        14359    14358       -1     
  Misses      15031    15031              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this change from a code perspective, but will wait for stellarator people to look and approve before merging, esp with the regression failures :)

@clmould clmould self-assigned this Jul 8, 2026
@timothy-nunn timothy-nunn requested a review from grmtrkngtn July 8, 2026 12:54
@jjwalkowiak

Copy link
Copy Markdown
Contributor

These two parts are responsible for two different scaling of available space. Both are necessary. I think in the version I use both of them work. I can check again tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expression value unused

5 participants