Skip to content

Make GitHub issue imports atomic and crash-resumable #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unbraind merged 3 commits into from
Jul 21, 2026
Merged

Make GitHub issue imports atomic and crash-resumable #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12f8dd4
feat(import): make GitHub issue sync atomic
unbraind Jul 21, 2026
5e66c6f
fix(import): make atomic dry-runs truthful
unbraind Jul 21, 2026
0735f7a
fix(import): harden atomic recovery edge cases
unbraind Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .agents/pm/features/pm-github-9eei.toon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ files[3]{path,scope,note}:
test/smoke.test.ts,project,null
tests[2]{command,scope,timeout_seconds}:
"npm run release:check",project,3600
rm -rf /tmp/pm-realdata-github && mkdir -p /tmp/pm-realdata-github && cd /tmp/pm-realdata-github && pm init >/dev/null && pm install /home/steve/container/pm-sweep/pm-github --project >/dev/null && pm github validate --repo unbraind/pm-cli --json > github-validate.json && pm github import unbraind/pm-cli --state open --dry-run --json > github-import-dryrun.json,project,1200
rm -rf /tmp/pm-realdata-github && mkdir -p /tmp/pm-realdata-github && cd /tmp/pm-realdata-github && pm init >/dev/null && pm install /workspace/pm-github --project >/dev/null && pm github validate --repo unbraind/pm-cli --json > github-validate.json && pm github import unbraind/pm-cli --state open --dry-run --json > github-import-dryrun.json,project,1200
close_reason: "Broad ecosystem-pass tracker from 2026-06-10; superseded by subsequent release waves. Package is at 2026.7.11, CI green, 0 alerts/issues. Closing stale tracker."
body: ""
9 changes: 5 additions & 4 deletions .agents/pm/history/pm-github-0y40.jsonl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{"ts":"2026-05-28T05:13:13.081Z","author":"codex","op":"create","patch":[{"op":"add","path":"/metadata/id","value":"pm-github-0y40"},{"op":"add","path":"/metadata/title","value":"Production-readiness audit 2026-05-28"},{"op":"add","path":"/metadata/description","value":""},{"op":"add","path":"/metadata/type","value":"Task"},{"op":"add","path":"/metadata/status","value":"in_progress"},{"op":"add","path":"/metadata/priority","value":2},{"op":"add","path":"/metadata/tags","value":[]},{"op":"add","path":"/metadata/created_at","value":"2026-05-28T05:13:13.081Z"},{"op":"add","path":"/metadata/updated_at","value":"2026-05-28T05:13:13.081Z"},{"op":"add","path":"/metadata/author","value":"codex"}],"before_hash":"3cc22dff72be7b14824654a7a64ea62b04799939b2fee54c1b5f52ca60bf6df0","after_hash":"7362819d08d4d9fd9bd74b07dfc2607f4f1509d534c5670f38457cdac4eac21a","message":""}
{"ts":"2026-05-29T21:59:07.300Z","author":"codex","op":"note_add","patch":[{"op":"replace","path":"/metadata/updated_at","value":"2026-05-29T21:59:07.300Z"},{"op":"add","path":"/metadata/notes","value":[{"created_at":"2026-05-29T21:59:07.300Z","author":"codex","text":"2026-05-29 functional readiness audit evidence.\n\nPackage checks from /home/steve/container/pm-packages/pm-github:\n- `npm run check`: exit 0, 6s.\n- `npm test`: exit 0, 13s; TAP reported `# tests 2`, `# pass 2`, `# fail 0`.\n- `npm run pack:dry-run`: exit 0, 9s; tarball `pm-github-2026.5.28.tgz`, package size 6.2 kB, unpacked size 20.1 kB, total files 9.\n- `npm run changelog:check`: exit 0, 3s; `Changelog is up to date: /home/steve/container/pm-packages/pm-github/CHANGELOG.md`.\n\nHands-on test used temporary workspace `/tmp/pm-core-audit-20260529/workspaces/pm-github.*` with local install `pm install /home/steve/container/pm-packages/pm-github`.\n- Ran no-token public import dry run: `env -u GITHUB_TOKEN -u GH_TOKEN pm --json gh-issues import octocat/Hello-World --dry-run --type Issue`.\n- Process exit code was 0, but command result was `{ \"error\": \"GitHub API returned HTTP 403\" }` after stderr `Failed to fetch: GitHub API returned HTTP 403`.\n- Follow-up GitHub issues endpoint probe returned HTTP 403 with `x-ratelimit-remaining=0`, confirming unauthenticated API rate limit for the caller IP.\n- `pm --json list-all | jq -e '.items | length == 0'`: exit 0; dry run/error path did not create local items.\n\nSensitive-data scan:\n- Current tracked files and git history scanned without printing matching values using pattern classes `private_key`, `provider_token`, `secret_assignment`, and `email_address`.\n- No matches found for pm-github.\n\nBlockers:\n- Hands-on GitHub public import could not complete because GitHub unauthenticated API quota was exhausted (HTTP 403, remaining 0).\n- The extension returned an error object while the CLI process exit code stayed 0; release readiness should decide whether fetch failures must produce non-zero exit status."}]}],"before_hash":"7362819d08d4d9fd9bd74b07dfc2607f4f1509d534c5670f38457cdac4eac21a","after_hash":"e275f4806aff3af6a5e33f33099493c1227a57eaae0296cb7d534fba2e2e5646","message":"Record 2026-05-29 functional readiness audit evidence"}
{"ts":"2026-05-29T22:03:16.538Z","author":"codex","op":"note_add","patch":[{"op":"add","path":"/metadata/notes/1","value":{"created_at":"2026-05-29T22:03:16.538Z","author":"codex","text":"2026-05-29 follow-up: fast-forwarded to current origin/main (v2026.05.29), which already contains the production hardening for authenticated GitHub requests, pagination, dry-run flag handling, and non-zero exit on fetch/create failures. Reapplied dependency floor updates to @unbrained/pm-cli ^2026.5.29, pm-changelog ^2026.5.29-2, peer @unbrained/pm-cli >=2026.5.29. Local gate after merge: npm run check PASS, npm test PASS (6 tests), npm run pack:dry-run PASS (pm-github-2026.5.29.tgz, 9 files, 8.2 kB). Regenerated CHANGELOG.md and changelog:check PASS."}},{"op":"replace","path":"/metadata/updated_at","value":"2026-05-29T22:03:16.538Z"}],"before_hash":"e275f4806aff3af6a5e33f33099493c1227a57eaae0296cb7d534fba2e2e5646","after_hash":"d1481dd50789a8ab51cea914e39739c299c7c0dcc96aabc6374c00a8cb731fb1","message":"Record pm-github merge verification"}
{"ts":"2026-05-29T22:33:12.706Z","author":"codex","op":"note_add","patch":[{"op":"add","path":"/metadata/notes/2","value":{"created_at":"2026-05-29T22:33:12.706Z","author":"codex","text":"2026-05-29 release-readiness refresh: package manifest/lock now target @unbrained/pm-cli >=2026.5.29 / ^2026.5.29 and pm-changelog ^2026.5.29-2 where applicable. Verified npm run check, npm test, npm run pack:dry-run, npm run audit:prod, npm run changelog:full, npm run changelog:check, npm run release:check, and pm validate. High-confidence worktree/history secret scan recorded no credential-shaped token findings for active package code; nonzero scan rows were classified as placeholders or vendored historical test data where applicable. Logs: /tmp/pm-active-package-gates-20260529.tsv, /tmp/pm-active-changelog-20260529.tsv, /tmp/pm-active-release-check-20260529.tsv, /tmp/pm-active-validate-20260529.tsv, /tmp/pm-active-secret-scan-20260529.tsv."}},{"op":"replace","path":"/metadata/updated_at","value":"2026-05-29T22:33:12.706Z"}],"before_hash":"d1481dd50789a8ab51cea914e39739c299c7c0dcc96aabc6374c00a8cb731fb1","after_hash":"44cf6a889799fef4d1f049e567621ab849680475789eeb72bdcfcb671c09bd03"}
{"ts":"2026-06-03T05:06:39.836Z","author":"codex","op":"close","patch":[{"op":"replace","path":"/metadata/updated_at","value":"2026-06-03T05:06:39.836Z"},{"op":"replace","path":"/metadata/status","value":"closed"},{"op":"add","path":"/metadata/close_reason","value":"Production-readiness audit completed in prior sweeps (rate-limit/backoff, pagination, exit codes all landed). Closing stale in_progress."}],"before_hash":"44cf6a889799fef4d1f049e567621ab849680475789eeb72bdcfcb671c09bd03","after_hash":"e1472c620bd0ca07bb5edb8c66775d11930c09fb3f21aa8e3276c26b16455b54"}
{"ts":"2026-05-29T21:59:07.300Z","author":"codex","op":"note_add","patch":[{"op":"replace","path":"/metadata/updated_at","value":"2026-05-29T21:59:07.300Z"},{"op":"add","path":"/metadata/notes","value":[{"created_at":"2026-05-29T21:59:07.300Z","author":"codex","text":"2026-05-29 functional readiness audit evidence.\n\nPackage checks from /workspace/pm-github:\n- `npm run check`: exit 0, 6s.\n- `npm test`: exit 0, 13s; TAP reported `# tests 2`, `# pass 2`, `# fail 0`.\n- `npm run pack:dry-run`: exit 0, 9s; tarball `pm-github-2026.5.28.tgz`, package size 6.2 kB, unpacked size 20.1 kB, total files 9.\n- `npm run changelog:check`: exit 0, 3s; `Changelog is up to date: /workspace/pm-github/CHANGELOG.md`.\n\nHands-on test used temporary workspace `/tmp/pm-core-audit-20260529/workspaces/pm-github.*` with local install `pm install /workspace/pm-github`.\n- Ran no-token public import dry run: `env -u GITHUB_TOKEN -u GH_TOKEN pm --json gh-issues import octocat/Hello-World --dry-run --type Issue`.\n- Process exit code was 0, but command result was `{ \"error\": \"GitHub API returned HTTP 403\" }` after stderr `Failed to fetch: GitHub API returned HTTP 403`.\n- Follow-up GitHub issues endpoint probe returned HTTP 403 with `x-ratelimit-remaining=0`, confirming unauthenticated API rate limit for the caller IP.\n- `pm --json list-all | jq -e '.items | length == 0'`: exit 0; dry run/error path did not create local items.\n\nSensitive-data scan:\n- Current tracked files and git history scanned without printing matching values using pattern classes `private_key`, `provider_token`, `secret_assignment`, and `email_address`.\n- No matches found for pm-github.\n\nBlockers:\n- Hands-on GitHub public import could not complete because GitHub unauthenticated API quota was exhausted (HTTP 403, remaining 0).\n- The extension returned an error object while the CLI process exit code stayed 0; release readiness should decide whether fetch failures must produce non-zero exit status."}]}],"before_hash":"7362819d08d4d9fd9bd74b07dfc2607f4f1509d534c5670f38457cdac4eac21a","after_hash":"cbb531316bc9e6c18001b7ac854eabaf7f10e5d8b744f000be0f1714c948d463","message":"Record 2026-05-29 functional readiness audit evidence"}
{"ts":"2026-05-29T22:03:16.538Z","author":"codex","op":"note_add","patch":[{"op":"add","path":"/metadata/notes/1","value":{"created_at":"2026-05-29T22:03:16.538Z","author":"codex","text":"2026-05-29 follow-up: fast-forwarded to current origin/main (v2026.05.29), which already contains the production hardening for authenticated GitHub requests, pagination, dry-run flag handling, and non-zero exit on fetch/create failures. Reapplied dependency floor updates to @unbrained/pm-cli ^2026.5.29, pm-changelog ^2026.5.29-2, peer @unbrained/pm-cli >=2026.5.29. Local gate after merge: npm run check PASS, npm test PASS (6 tests), npm run pack:dry-run PASS (pm-github-2026.5.29.tgz, 9 files, 8.2 kB). Regenerated CHANGELOG.md and changelog:check PASS."}},{"op":"replace","path":"/metadata/updated_at","value":"2026-05-29T22:03:16.538Z"}],"before_hash":"cbb531316bc9e6c18001b7ac854eabaf7f10e5d8b744f000be0f1714c948d463","after_hash":"6472a00ed8cf9bc8c2ff9d520bcdf6adaae3c9942ed3a0a598cd84dda063672c","message":"Record pm-github merge verification"}
{"ts":"2026-05-29T22:33:12.706Z","author":"codex","op":"note_add","patch":[{"op":"add","path":"/metadata/notes/2","value":{"created_at":"2026-05-29T22:33:12.706Z","author":"codex","text":"2026-05-29 release-readiness refresh: package manifest/lock now target @unbrained/pm-cli >=2026.5.29 / ^2026.5.29 and pm-changelog ^2026.5.29-2 where applicable. Verified npm run check, npm test, npm run pack:dry-run, npm run audit:prod, npm run changelog:full, npm run changelog:check, npm run release:check, and pm validate. High-confidence worktree/history secret scan recorded no credential-shaped token findings for active package code; nonzero scan rows were classified as placeholders or vendored historical test data where applicable. Logs: /tmp/pm-active-package-gates-20260529.tsv, /tmp/pm-active-changelog-20260529.tsv, /tmp/pm-active-release-check-20260529.tsv, /tmp/pm-active-validate-20260529.tsv, /tmp/pm-active-secret-scan-20260529.tsv."}},{"op":"replace","path":"/metadata/updated_at","value":"2026-05-29T22:33:12.706Z"}],"before_hash":"6472a00ed8cf9bc8c2ff9d520bcdf6adaae3c9942ed3a0a598cd84dda063672c","after_hash":"1a78ffe541977d98dc195bb47a2fb085b4b5ad4d1d8c029b99fc9ed3451bb39a"}
{"ts":"2026-06-03T05:06:39.836Z","author":"codex","op":"close","patch":[{"op":"replace","path":"/metadata/updated_at","value":"2026-06-03T05:06:39.836Z"},{"op":"replace","path":"/metadata/status","value":"closed"},{"op":"add","path":"/metadata/close_reason","value":"Production-readiness audit completed in prior sweeps (rate-limit/backoff, pagination, exit codes all landed). Closing stale in_progress."}],"before_hash":"1a78ffe541977d98dc195bb47a2fb085b4b5ad4d1d8c029b99fc9ed3451bb39a","after_hash":"2c6f2bcba3dee96b31c8965ad533294ec589da483c6c9985c214812ec08c17a6"}
{"ts":"2026-07-21T07:08:42.175Z","author":"codex","op":"history_redact","patch":[],"before_hash":"2c6f2bcba3dee96b31c8965ad533294ec589da483c6c9985c214812ec08c17a6","after_hash":"2c6f2bcba3dee96b31c8965ad533294ec589da483c6c9985c214812ec08c17a6","message":"Redact legacy absolute host path from published tracker evidence"}
Loading