fix(docker): authenticate rate limit Redis storage#2043
Open
harshmathurx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The Docker entrypoint protects the in-container Redis with
REDIS_PASSWORD, but older/self-managed configs can still pointrate_limiting.storage_uriatredis://localhost:6379without credentials. SlowAPI/limits then touches Redis before the route handler and fails during the Redis HELLO handshake.Fixes #2040.
Test plan
python3 -m py_compile deploy/docker/redis_config.py deploy/docker/server.py deploy/docker/tests/test_security_default_posture.pyPYTHONPATH=deploy/docker uv run --no-project --with pytest pytest deploy/docker/tests/test_security_default_posture.py -k 'redis_url_includes_acl_username or rate_limit_redis_storage_reuses_redis_password or rate_limit_storage_preserves_explicit_auth or rate_limit_storage_keeps_memory_backend' -qPYTHONPATH=deploy/docker uv run --no-project --with pytest pytest deploy/docker/tests/test_security_container_posture.py -k 'not sandbox' -qNote: full Docker/runtime reproduction was not possible in this environment because the local Docker daemon is not running.