fix: handle client close event - #8
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 64.98% 65.08% +0.09%
==========================================
Files 8 8
Lines 1048 1051 +3
Branches 73 74 +1
==========================================
+ Hits 681 684 +3
Misses 366 366
Partials 1 1
|
pi0
reviewed
Sep 1, 2023
pi0
approved these changes
Sep 1, 2023
Member
|
Thanks for this PR. LGTM. It is worth to also check other upstream PRs for abort handling http-party/node-http-proxy#1580 http-party/node-http-proxy#1559 |
1 task
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Downstream discussion: nuxt/nuxt#16046
❓ Type of change
📚 Description
Proxy respond did not get 'abort/destroy' when the client close the request, causing situation in Server sent event where user trigger
closefrom the clinet EventSource, but the server request did not trigger thecloselisten as expected.Reproduction: https://stackblitz.com/edit/unjs-nitro-khtcjd?file=routes%2Fsse.ts
Server Sent Event(SSE) example code: https://gist.github.com/Atinux/05836469acca9649fa2b9e865df898a2
Downstream discussion: nuxt/nuxt#16046
Related issues: http-party/node-http-proxy#1520
📝 Checklist