Implement JsonSerializable interface on AbstractUnzerResource and ApplepaySession#235
Draft
Ryouzanpaku wants to merge 4 commits into
Draft
Implement JsonSerializable interface on AbstractUnzerResource and ApplepaySession#235Ryouzanpaku wants to merge 4 commits into
Ryouzanpaku wants to merge 4 commits into
Conversation
…rmCharge and performSca. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…er intent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ce and ApplepaySession. jsonSerialize() now returns expose() data instead of a pre-encoded string, making json_encode($resource) work correctly for all resources. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbstractUnzerResourcenow implements\JsonSerializable;jsonSerialize()returnsexpose()data instead of a pre-encoded string, makingjson_encode($resource)work correctly for all resourcesApplepaySessionreceives the same fix — implements\JsonSerializableand returnsget_object_vars($this)fromjsonSerialize()HttpServiceandApplepayAdapterupdated to usejson_encode($resource, ...)instead of callingjsonSerialize()directlyResolves CC-3759
Dependencies
CC-3759/keypair-protected-properties) first — that change enablesKeypairproperties to be included in theexpose()output this PR relies on.🤖 Generated with Claude Code