test(cmd/urunc): add unit tests for parseSignal and validate positive signal range - #920
Open
ParthMozarkar wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for urunc canceled.
|
… signal range Signed-off-by: ParthMozarkar <greatparth21@gmail.com>
ParthMozarkar
force-pushed
the
test/kill-signal-validation-tests
branch
from
August 7, 2026 19:55
7d17256 to
38d2a63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves signal parsing validation in
cmd/urunc/kill.goand introduces unit test coverage forcmd/urunc.Description of Changes
parseSignal()incmd/urunc/kill.goto reject non-positive numeric signal inputs (<= 0) with a descriptive error message (invalid signal number %d: must be positive).cmd/urunc/kill_test.gowith table-driven tests covering:SIGKILL,KILL,kill,SIGTERM)9,15)0,-1)SIGUNKNOWN,FOOBAR)Related Issue
Closes #917
Verification & Testing
cmd/urunc/kill_test.goverifying signal parsing edge cases.