feat(tests): enhance sideContainers to support multi-containers tests - #924
Open
alimx07 wants to merge 1 commit into
Open
feat(tests): enhance sideContainers to support multi-containers tests#924alimx07 wants to merge 1 commit into
alimx07 wants to merge 1 commit into
Conversation
✅ Deploy Preview for urunc canceled.
|
Signed-off-by: Ali Mohamed <amx746@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhance a
SideContainersfeature to the e2e test framework, with current spec (Name,Image,Cli,Volumes,NetMode) that can run alongside the primary unikernel, either joining its same named network or sharing its network namespace directly according to mode.Related issues
How was this tested?
Still do not tested yet. I think the most easiet test will be a network calls on the localhost, so this is blocked until #793 merged.
LLM usage
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).