Skip to content

fix(ptx): missing filename in error messages#13251

Open
HackingRepo wants to merge 3 commits into
uutils:mainfrom
HackingRepo:patch-6
Open

fix(ptx): missing filename in error messages#13251
HackingRepo wants to merge 3 commits into
uutils:mainfrom
HackingRepo:patch-6

Conversation

@HackingRepo

Copy link
Copy Markdown

Fixes #13036

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)

@codspeed-hq

codspeed-hq Bot commented Jul 2, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 331 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing HackingRepo:patch-6 (b0a40be) with main (2a92fcc)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@HackingRepo

Copy link
Copy Markdown
Author

codspeed is confusing for benchmarks, it says will degrade permission for sort, but i targeted ptx, so what will do with it? i seen it report false perfomance reports, i modified only ptx

@HackingRepo

Copy link
Copy Markdown
Author

Hi, @sylvestre

i appreciate it, the uutils project will be soon less buggy, i'm now opening pr after identified massive issue, so can you review that when you have time, please

Comment thread tests/by-util/test_ptx.rs
}

#[test]
fn test_missing_file_error_contains_filename() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please test the full error message

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i will do

@HackingRepo HackingRepo requested a review from sylvestre July 3, 2026 06:41
@HackingRepo

HackingRepo commented Jul 3, 2026

Copy link
Copy Markdown
Author

Hi @sylvestre, now i corrected what you said me, i tested the full error message is anything remaining or you will merge, thank's, take your time no rush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ptx: missing path on no such file or directory error

2 participants