locale: fix incomplete fallback bundles#13257
Open
BAMF0 wants to merge 2 commits into
Open
Conversation
Fix an error where only the common strings would be used when falling back to embedded locales. This lead to an issue where the raw Fluent message keys were returned rather than actual error messages, such as `wc-error-failed-to-print-result` instead of "failed to print result". Additionally, preserve partial resources instead of discarding everything when not all messages could be parsed.
|
GNU testsuite comparison: |
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
|
could you please add a test to make sure we don't regress in the future? |
Contributor
Author
|
Ah yes of course! Good catch |
Contributor
Author
|
There we go. It was a bit tricky to reproduce outside of the Ubuntu package build pipeline, but I managed to figure it out. I have updated my issue with the reproduction steps as well for future reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an error where only the common strings would be used when falling back to embedded locales. This lead to an issue where the raw Fluent message keys were returned rather than actual error messages, such as wc-error-failed-to-print-result instead of "failed to print result".
Additionally, preserve partial resources instead of discarding everything when not all messages could be parsed.
Fixes #11854