head: don't panic on a write error while printing a verbose header#13265
Open
leeewee wants to merge 1 commit into
Open
head: don't panic on a write error while printing a verbose header#13265leeewee wants to merge 1 commit into
leeewee wants to merge 1 commit into
Conversation
The verbose `==> name <==` header wrote the filename with `print_verbatim(file).unwrap()`, while the surrounding writes use `?`. When the filename is longer than the stdout buffer, `write_all` flushes mid-write, so a write error (e.g. stdout on a full device) is raised inside the `unwrap` and aborts the process instead of being reported. Propagate the error with `?` like the neighbouring header writes, so a write failure exits non-zero with a message instead of panicking, regardless of filename length.
|
GNU testsuite comparison: |
Merging this PR will improve performance by 4.85%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13264
The verbose
==> name <==header wrote the filename withprint_verbatim(file).unwrap(), while the surrounding header writes use?. When the filename is longer than the stdout buffer (~1024 bytes),write_allflushes mid-write, so a write error (e.g. stdout on a full device) is raised inside theunwrapand aborts the process instead of being reported.This propagates the error with
?like the neighbouring writes, so a write failure exits non-zero with a message instead of panicking, regardless of filename length.Before:
After (consistent with the short-filename path, and non-zero like GNU):
A regression test (
test_verbose_header_long_name_write_error_no_panic) covers it with.fails_with_code(1), which the pre-fix abort would not satisfy.