Skip to content

fix: invalid configurator state breaks "copy and edit this visualization" button #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mburri merged 3 commits into from
Jul 10, 2026
Merged

fix: invalid configurator state breaks "copy and edit this visualization" button #2596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ee8595
fix: first draft
mburri Jul 9, 2026
cff8cc6
fix: make measure id truly optional - no need for new chart config ve…
mburri Jul 9, 2026
65a0ec6
doc: add changelog entry
mburri Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,16 @@ You can also check the
## Unreleased

- Fixes

- Correctly set CSP headers for index pages
- Harden markdown renderer sanitization
- Make measure id optional for symbol layers in map charts. Fixes issues with
invalid view configuration that prevents that users could copy and edit an
existing visualization

- Maintenance
- Add dev-container support


## 6.5.0 – 2026-06-01

- Features
Expand Down
3 changes: 1 addition & 2 deletions app/charts/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ import {
TableFields,
} from "@/config-types";
import { mapValueIrisToColor } from "@/configurator/components/ui-helpers";
import { FIELD_VALUE_NONE } from "@/configurator/constants";
import {
Component,
Dimension,
Expand Down Expand Up @@ -321,7 +320,7 @@ const getInitialSymbolLayer = ({
}): MapSymbolLayer => {
return {
componentId: component.id,
measureId: measure?.id ?? FIELD_VALUE_NONE,
measureId: measure?.id,
color: DEFAULT_FIXED_COLOR_FIELD,
};
};
Expand Down
2 changes: 1 addition & 1 deletion app/charts/shared/chart-helpers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ const getMapChartConfigAdditionalFieldIds = ({ fields }: MapConfig) => {
}

if (symbolLayer) {
if (symbolLayer.measureId !== FIELD_VALUE_NONE) {
if (symbolLayer.measureId && symbolLayer.measureId !== FIELD_VALUE_NONE) {
additionalFields.push(symbolLayer.measureId);
}

Expand Down
22 changes: 15 additions & 7 deletions app/config-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,13 +948,21 @@ const MapAreaLayer = t.type({
});
export type MapAreaLayer = t.TypeOf<typeof MapAreaLayer>;

const MapSymbolLayer = t.type({
componentId: t.string,
/** Symbol radius (size) */
measureId: t.string,
// FIXME: convert to new color field type
color: t.union([FixedColorField, CategoricalColorField, NumericalColorField]),
});
const MapSymbolLayer = t.intersection([
t.type({
componentId: t.string,
// FIXME: convert to new color field type
color: t.union([
FixedColorField,
CategoricalColorField,
NumericalColorField,
]),
}),
t.partial({
/** Symbol radius (size) */
measureId: t.string,
}),
]);
export type MapSymbolLayer = t.TypeOf<typeof MapSymbolLayer>;

const BaseCustomLayer = t.type({
Expand Down
Loading