feat(rsc): expose directive function validation - #1412
Draft
hi-ogawa wants to merge 13 commits into
Draft
Conversation
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
hi-ogawa
changed the title
hi-ogawa
commented
Aug 6, 2026
Comment on lines
+15
to
+20
| /** | ||
| * Applies the function restrictions used by Next.js Server Functions. | ||
| * Unknown and non-function values are ignored so transform callbacks can pass | ||
| * `meta.valueNode` directly. | ||
| */ | ||
| export function validateDirectiveFunction( |
Contributor
Author
There was a problem hiding this comment.
TODO: next.js reference
hi-ogawa
commented
Aug 6, 2026
Comment on lines
+44
to
+47
| const wrap = (value: string, name: string, meta: ModuleExportMeta) => { | ||
| validateDirectiveFunction(meta.valueNode, directive) | ||
| return runtime(value, name, getCacheWrapperOptions(meta)) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
nit. just unify wrap and runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
Inline and file directive transforms expose their source value through
meta.valueNode, but integrations currently need to reimplement the Next.js restrictions aroundthis,super, andarguments. Baking those checks into generic hoist and export transforms would also impose Server Function policy on unrelated consumers.This PR exposes
validateDirectiveFunctionso directive owners can compose the checks through their existingruntimeorgeneratecallbacks. It wires the built-in"use server"transform and maintained custom/"use cache"examples while leaving generic transforms unchanged. Validation covers direct file exports available through currentvalueNodemetadata; local identifier export resolution remains separate following #1380.