Conversation
Pass 1 counts mainline SAN tokens per game (tokenizer-only, no SAN parsing) to compute exact output sizes and per-game CSR offsets. Pass 2 parses
Two-pass parsing replaces the per-chunk Buffers architecture: pass 1 counts SAN tokens per game to size and offset every output array exactly; pass 2 parses in parallel over small game tasks with rayon work stealing, each game writing into its precomputed disjoint slice. No merge step, no reallocs, no per-thread straggler tail. The GIL is released during both passes. Breaking Python API changes: - ParsedGames now exposes flat global arrays directly (boards, from_squares, move_offsets, ..., parsed_move_counts); .chunks, num_chunks, PyChunkView and the chunk_multiplier parameter are gone. - Invalid games keep their pre-counted array range with sentinel- filled tails; parsed_move_counts records actual moves. PyGameView still exposes only the parsed prefix, matching 4.x semantics. - Buffers/GameVisitor (src/visitor.rs) deleted; core entry point is parse_games_flat, shared by the pyo3 layer and the native bench. Validation: byte-identical outputs vs 4.0.0 on the lichess 2013-07 corpus (293k games, compare_reference.py), cargo test + test.py green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.