parts/gp2y0a21: body-relative lens and connector placement - #685
Merged
Conversation
box() anchors at the origin corner, so the lens pair and connector coordinates must be body-relative — the first cut placed them on a centred frame and the left lens floated off the housing (the catalog bbox read 43 mm wide for a 29.5 mm body). Signed-off-by: Andrii Shylenko <14119286+w1ne@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
box() anchors at the origin corner, so the lens pair and connector coordinates must be body-relative — the first cut placed them on a centred frame and the left lens floated off the housing (the catalog bbox read 43 mm wide for a 29.5 mm body). Evaluates clean: 9 parts, no warnings.