Skip to content

chore(deps): update dependency @types/node to v26 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency @types/node to v26 #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"devDependencies": {
"@sentry/node": "^9.4.0",
"@types/inquirer": "^9.0.7",
"@types/node": "^22.13.0",
"@types/node": "^26.0.0",

@devin-ai-integration devin-ai-integration Bot Aug 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Type definitions no longer match the oldest supported Node version

The project's Node type definitions are jumped to a major version that targets a much newer runtime ("@types/node": "^26.0.0" at package.json:74) while the project still declares support for Node 18 and up, so code can be type-checked as valid yet fail on the older runtimes users are told are supported.
Impact: Users on Node 18/20 may hit runtime errors from APIs that appear available during development.

Why the type-package major and the engines range must agree

package.json:49-51 declares "engines": { "node": ">=18.0.0" }, and tsconfig.json sets "types": ["node"]. DefinitelyTyped's @types/node majors track a specific Node major line; a v26 typings set describes APIs (and API-shape changes) present only in much newer Node, so builds silently permit usage unavailable on Node 18/20. Either keep the typings aligned with the minimum supported major, or raise the engines floor along with this bump.

Prompt for agents 
package.json declares engines.node >= 18.0.0 but the devDependency @types/node was bumped to ^26.0.0, whose typings correspond to a much newer Node major. Since tsconfig.json includes "types": ["node"], type-checking will accept APIs that don't exist on Node 18/20. Decide whether to keep @types/node pinned to the major matching the minimum supported Node version, or to raise the engines floor (and document it in CHANGELOG.md as a user-facing change).
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@devin-ai-integration devin-ai-integration Bot Aug 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changelog not updated for the dependency change

The repository's contributor rules require the Unreleased section of the changelog to be updated for user-facing changes, but this change ("@types/node": "^26.0.0" at package.json:74) leaves the Unreleased section empty, so the release notes don't reflect what changed.
Impact: Maintainers and users lose track of what shipped in the next release.

Rule reference

AGENTS.md states: "Conventional Commit titles; update CHANGELOG.md (Unreleased) for user-facing changes." CHANGELOG.md currently has an empty ## [Unreleased] section. If this dependency bump is considered non-user-facing, no entry is needed; but combined with the supported-Node implications it is worth an entry.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@devin-ai-integration devin-ai-integration Bot Aug 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Only a typings devDependency changed; no runtime code affected

The diff touches only package.json:74 (@types/node bump). No source files, build config, or lockfile updates accompany it. tsconfig.json uses "types": ["node"] with skipLibCheck: true, so third-party typing breakage is mostly masked, but the repo's own code is still checked against the new typings — worth confirming npm run type-check and npm test pass on CI before merge, since major @types/node bumps frequently change signatures (e.g. Buffer, stream, and process APIs).

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"@types/ws": "^8.5.14",
"tsup": "^8.0.0",
"typescript": "^5.9.3",
Expand Down
Loading