Php8 compatibility#1
Open
fabianaromagnoli wants to merge 16 commits into
Open
Conversation
mmenozzi
reviewed
Nov 16, 2022
fabianaromagnoli
marked this pull request as ready for review
November 18, 2022 10:07
fabianaromagnoli
force-pushed
the
php8-compatibility
branch
from
November 18, 2022 10:56
59b6594 to
7af180a
Compare
The only usage of Yaml in this fork is Symfony\Component\Yaml\Yaml::parse() (app/code/community/EcomDev/PHPUnit/Model/Yaml/Loader.php), an API stable across all these majors. Needed to unblock newer packages that require symfony/yaml >=5.4.
Allow symfony/yaml ^5.4 and ^6.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qua è stata mergiata, ma non so quando verrà taggata, quindi intanto possiamo usare questo branch del fork su IC. Dategli un occhio se vi torna tutto: i file modificati sono tanti ma la maggior parte sono namespace.